Satheesh Bandaram wrote:
I am not exactly objecting :-) , but it would be nice to add a test
case to show the problem the fix is attempting to fix. I suspect the
original issue is easy to introduce, but hard to catch.
While we are on this topic, I noticed SetQueryTimeoutTest test takes
around 30-40 minutes on my laptop. On one of our build machines, it
actually runs for longer than 2 hours when the test harness actually
kills the test. (causing the test to fail everytime) Though this is more
of our test machine problem (it is really sloooow), taking 30-40 minutes
for one functional test seems too long. Is there anyway the test can be
made to run faster?
You realize that you are making conflicting requests, don't you? ;-)
More tests in less time!
I ran the test in 15 minutes, which is less than what you are
experiencing, but I still think it is too much. I'll look into making
the test run faster. The problem is that it's hard to tune the size of
the tables so you're "guaranteed" that the fetching of some rows will
take longer than the timeout value.
I'll also look at adding a testcase for the bug that this patch addresses.
--
Oyvind Bakksjo
Sun Microsystems, Database Technology Group
Trondheim, Norway
http://weblogs.java.net/blog/bakksjo/
