Hello.
I have one question ...
I looked at the patch briefly, and had one minor comment. In convertToAsciiByteArray, it might be better performance wise, if we
calculate the original.length only once and use it in the for loop.
Can it be improvement of performance so much ?
Length of String object cannot be changed and there would be very less
performance improvement .
//Improvement would be just saving time of calling method .
Rather, I feel question for adding (local) variable , because I don't want to
increase number of variable even if it is local ....
Best regards.
/*
Tomohito Nakayama
[EMAIL PROTECTED]
[EMAIL PROTECTED]
[EMAIL PROTECTED]
Naka
http://www5.ocn.ne.jp/~tomohito/TopPage.html
*/
----- Original Message -----
From: "Sunitha Kambhampati (JIRA)" <[email protected]>
To: <[email protected]>
Sent: Friday, September 30, 2005 2:13 AM
Subject: [jira] Commented: (DERBY-525) getAsciiStreamshould replace non-ASCII
characters with 0x3f, '?' to match embedded
[
http://issues.apache.org/jira/browse/DERBY-525?page=comments#action_12330828 ]
Sunitha Kambhampati commented on DERBY-525:
-------------------------------------------
It would be great if you could add a testcase for this.
I looked at the patch briefly, and had one minor comment. In convertToAsciiByteArray, it might be better performance wise, if we
calculate the original.length only once and use it in the for loop.
getAsciiStreamshould replace non-ASCII characters with 0x3f, '?' to match
embedded
-----------------------------------------------------------------------------------
Key: DERBY-525
URL: http://issues.apache.org/jira/browse/DERBY-525
Project: Derby
Type: Bug
Components: Network Client
Versions: 10.1.2.0, 10.1.1.0, 10.2.0.0
Reporter: Kathey Marsden
Assignee: Tomohito Nakayama
Fix For: 10.2.0.0
Attachments: DERBY-525.patch, DERBY-525.site.patch, derbyall_report.txt
When calling Clob.getAsciiStream or ResultSet.getAsciiStream if
the column type is a character type or a CLOB, then any out of
range character (to the ASCII set) needs to be replaced by 0x3f
('?', question mark). ASCII is defined as 8 bit characters,
thus Unicode Characters in the range 0x0000 to 0x00ff are
mapped to ASCII characters 0x00 to 0xff, and Unicode characters
in the range 0x0100 to 0xffff are mapped to 0x3f
By code inspection:
client code in
org.apache.derby.client.am.ResultSet
embedded in
org.apache.derby.impl.jdbc.ReaderToAscii
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
--
No virus found in this incoming message.
Checked by AVG Anti-Virus.
Version: 7.0.344 / Virus Database: 267.11.8/114 - Release Date: 2005/09/28
--
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.344 / Virus Database: 267.11.8/114 - Release Date: 2005/09/28
