I thought at some point we agreed that at least one independent party
should run the tests; this happened after a patch failed to pass tests
even though it built -- I think the patch didn't contain a new master
file that had been added.
It would be nice to add guidelines for checking in a patch to our Wiki
site...
David
Øyvind Bakksjø wrote:
David W. Van Couvering wrote:
Has somebody other than Narayanan pulled it, built it, and run the tests?
David
I always check that stuff builds before committing. As for running the
tests, we usually consider it sufficient if the contributor has run
tests without failure and a reviewer approves the patch, don't we?
begin:vcard
fn:David W Van Couvering
n:Van Couvering;David W
org:Sun Microsystems, Inc.;Database Technology Group
email;internet:[EMAIL PROTECTED]
title:Senior Staff Software Engineer
tel;work:510-550-6819
tel;cell:510-684-7281
x-mozilla-html:TRUE
version:2.1
end:vcard
