[ 
https://issues.apache.org/jira/browse/DERBY-3398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13581143#comment-13581143
 ] 

Knut Anders Hatlen commented on DERBY-3398:
-------------------------------------------

Thanks, Dag.

The patch looks fine to me. You may want to double-check if it builds if you 
have the j15lib property defined. I suspect it may fail because the tests 
directly reference the MIN_NORMAL constants, which are new in Java 6.

In the release note, the summary is supposed to be a single sentence that fits 
on a single line, so that the release note generator can put it into a bullet 
list. Maybe just keep the first sentence and move the extra details to the 
symptoms section?

Typo in incompatibilities section: "can no" -> "cannot" or, perhaps, "can no 
longer"?

In Application Changes Required section: "to detect when use of numbers outside 
the DB2 limits were used". Drop "use of"?
                
> Support min/max values for Java types float/double in real/double columns
> -------------------------------------------------------------------------
>
>                 Key: DERBY-3398
>                 URL: https://issues.apache.org/jira/browse/DERBY-3398
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 10.4.1.3
>            Reporter: Knut Anders Hatlen
>            Assignee: Dag H. Wanvik
>            Priority: Minor
>              Labels: derby_triage10_10
>         Attachments: derby-3398-2.diff, derby-3398-3.diff, derby-3398-3.stat, 
> derby-3398-4.diff, derby-3398-5.diff, derby-3398-5.stat, derby-3398-7.diff, 
> derby-3398-7.stat, derby-3398.diff, derby-3398.status, releaseNote.html
>
>
> Derby doesn't support the entire range of valid (finite) values of the Java 
> primitive types double/float in columns with SQL type DOUBLE or REAL. This 
> appears to be a limitation that was introduced for compatibility with DB2. 
> There have been some requests on derby-user that we lift this restriction.
> The restriction is enforced by the methods normalizeREAL() and 
> normalizeDOUBLE() in org.apache.derby.iapi.types.NumberDataType.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to