Committed. >>>>>>>>>>>> Mamta Satoor wrote (2005-11-03 09:14:49): > Hi Bernt, > Thanks for trying out the patch so quickly. The problem was that I didn't > have the properties usedefaults=true in > unaryArithmeticDynamicParameter_app.properties. This property causes the > properties from default_app.properties to be used for > unaryArithmeticDynamicParameter test. I have attached the new patch to this > mail (also added some relevant comments to the > unaryArithmeticDynamicParameter_app.properties file) > svn stat output stays the same > M > java\testing\org\apache\derbyTesting\functionTests\tests\lang\copyfiles.ant > A > java\testing\org\apache\derbyTesting\functionTests\tests\lang\unaryArithmeticDynamicParameter_app.properties > thanks, > Mamta > On 11/3/05, Bernt M. Johnsen <[EMAIL PROTECTED]> wrote: > > > > >>>>>>>>>>>> Mamta Satoor wrote (2005-11-02 23:31:41): > > > Hi, > > > I have a minor patch to skip lang/unaryArithmeticDynamicParameter.java > > test > > > under jdk13. The reason for skipping is metadata calls for > > ParameterMetaData > > > are not available in jdk13 and the primary purpose of the test is to > > check > > > the metadata information about the unary minus/plus parameter. The test > > will > > > continue to run under higher jdks. > > > svn stat > > > M > > > > > java\testing\org\apache\derbyTesting\functionTests\tests\lang\copyfiles.ant > > > A > > > > > java\testing\org\apache\derbyTesting\functionTests\tests\lang\unaryArithmeticDynamicParameter_app.properties > > > thanks, > > > > When running derbylang after the patch was appiled I got: > > > > Test using parameters for unary minus and unary plus > > Exception in thread "main" java.lang.NullPointerException > > at > > org.apache.derbyTesting.functionTests.tests.lang.unaryArithmeticDynamicParameter.main > > (unaryArithmeticDynamicParameter.java:44) > > > > for the lang/unaryArithmeticDynamicParameter test. > > > > I was running the tests on > > > > Java Version: 1.4.2_05 > > Java Vendor: Sun Microsystems Inc. > > OS name: Linux > > OS architecture: i386 > > OS version: 2.6.13-1.1532_FC4 > > > > > Mamta > > > > > Index: > > java/testing/org/apache/derbyTesting/functionTests/tests/lang/copyfiles.ant > > > =================================================================== > > > --- > > java/testing/org/apache/derbyTesting/functionTests/tests/lang/copyfiles.ant > > (revision 330499) > > > +++ > > java/testing/org/apache/derbyTesting/functionTests/tests/lang/copyfiles.ant > > (working copy) > > > @@ -228,6 +228,7 @@ > > > triggerStream.sql > > > triggerStream_app.properties > > > triggerStream_derby.properties > > > +unaryArithmeticDynamicParameter_app.properties > > > ungroupedAggregatesNegative.sql > > > union.sql > > > unlimited.sql > > > Index: > > java/testing/org/apache/derbyTesting/functionTests/tests/lang/unaryArithmeticDynamicParameter_app.properties > > > =================================================================== > > > --- > > java/testing/org/apache/derbyTesting/functionTests/tests/lang/unaryArithmeticDynamicParameter_app.properties > > (revision 0) > > > +++ > > java/testing/org/apache/derbyTesting/functionTests/tests/lang/unaryArithmeticDynamicParameter_app.properties > > (revision 0) > > > @@ -0,0 +1,22 @@ > > > +# > > > +# This is the default system properties file for SQL and JAVA tests. > > > +# > > > +# *** DO NOT PUT PROPERTIES FOR THE DERBY SYSTEM IN THIS FILE. > > > +# *** THEY BELONG IN default_derby.properties. > > > +# > > > +# This file will get handed to the test on the command line in a -p > > <filename> > > > +# argument. > > > +# > > > +# This causes ij to load the driver and make an > > > +# initial connection to the database. > > > +# > > > +# The .java test has to call util.getPropertyArg and util.startJBMS > > > +# to process the property file. See any of the .java tests for this > > code. > > > +# > > > +# If you want to alter these to use a different driver, connect to a > > different > > > +# database, or to not be used, override this file by creating > > > +# a file <testname>_app.properties to be used instead of this file. > > > +# > > > + > > > +runwithibm13=false > > > +runwithjdk13=false > > > > > > Property changes on: > > java/testing/org/apache/derbyTesting/functionTests/tests/lang/unaryArithmeticDynamicParameter_app.properties > > > ___________________________________________________________________ > > > Name: svn:eol-style > > > + native > > > > > > > > > -- > > Bernt Marius Johnsen, Database Technology Group, > > Sun Microsystems, Trondheim, Norway > > > > > >
> Index: > java/testing/org/apache/derbyTesting/functionTests/tests/lang/copyfiles.ant > =================================================================== > --- > java/testing/org/apache/derbyTesting/functionTests/tests/lang/copyfiles.ant > (revision 330499) > +++ > java/testing/org/apache/derbyTesting/functionTests/tests/lang/copyfiles.ant > (working copy) > @@ -228,6 +228,7 @@ > triggerStream.sql > triggerStream_app.properties > triggerStream_derby.properties > +unaryArithmeticDynamicParameter_app.properties > ungroupedAggregatesNegative.sql > union.sql > unlimited.sql > Index: > java/testing/org/apache/derbyTesting/functionTests/tests/lang/unaryArithmeticDynamicParameter_app.properties > =================================================================== > --- > java/testing/org/apache/derbyTesting/functionTests/tests/lang/unaryArithmeticDynamicParameter_app.properties > (revision 0) > +++ > java/testing/org/apache/derbyTesting/functionTests/tests/lang/unaryArithmeticDynamicParameter_app.properties > (revision 0) > @@ -0,0 +1,10 @@ > +# > +# This test should not get run under jdk13 because it relies on jdk14 jdbc > metadata calls. > +# The metadata calls are required to ensure that the parameter type for > dynamic parameter > +# for unary minus and plus get set correctly from the context in which they > are used. > +# > + > +runwithibm13=false > +runwithjdk13=false > + > +usedefaults=true > > Property changes on: > java/testing/org/apache/derbyTesting/functionTests/tests/lang/unaryArithmeticDynamicParameter_app.properties > ___________________________________________________________________ > Name: svn:eol-style > + native > > -- Bernt Marius Johnsen, Database Technology Group, Sun Microsystems, Trondheim, Norway
pgpWBRkqZS7E6.pgp
Description: PGP signature
