[
https://issues.apache.org/jira/browse/DERBY-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dag H. Wanvik updated DERBY-6125:
---------------------------------
Attachment: derby-6125-05-c.status
derby-6125-05-c.diff
Thanks for looking at patch 05-a, Knut. I have made Sqlca#getSqlErrd as you
suggested, plus:
- made ClientXid#getData clone the result
- removed unused methods EncryptionManager#setInitVector and #setSecKey
- introduced public String Sqlca#formatSqlErrd as replacement
- changed #getSqlWarn to return String since all its uses need a String anyway.
- changed arraycopy in Section#getPKGNAMCBytes to to use clone instead
- make Section#getPKGNAMCBytes to return a clone
- simplified implementation of Sqlca#getSqlWarn
- removed argument sqlErrpBytes from Sqlca#setContainsSqlcax (only called once;
with null).
- introduced Sqlca#getReturnValue in Statement#completeExecute instead of
allowing access to sqlca.getSqlErrd()[0]
Rerunning regressions.
> Code clean up in client driver.
> -------------------------------
>
> Key: DERBY-6125
> URL: https://issues.apache.org/jira/browse/DERBY-6125
> Project: Derby
> Issue Type: Improvement
> Components: Network Client
> Reporter: Dag H. Wanvik
> Attachments: derby-6125-01-a.diff, derby-6125-01-b.diff,
> derby-6125-01-b.status, derby-6125-02-a.diff, derby-6125-02-a.status,
> derby-6125-03-04-followup.diff, derby-6125-03-04-followup.status,
> derby-6125-03-a.diff, derby-6125-03-a.status, derby-6125-04-a.diff,
> derby-6125-04-a.status, derby-6125-05-a.diff, derby-6125-05-c.diff,
> derby-6125-05-c.status
>
>
> Clean up unused code, lacking finals, too wide visibility etc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
