[ 
https://issues.apache.org/jira/browse/DERBY-6168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Knut Anders Hatlen updated DERBY-6168:
--------------------------------------

    Attachment: D6168.java

Actually, it's not only Formatable classes that can be referenced, it's enough 
that they implement TypedFormat (which is a super-interface of Formatable). 
Classes that implement InstanceGetter could also be there.

I ran the attached program (D6168.java) that goes through the classes in 
RegisteredFormatIds and reports problems. Apart from the rts classes fixed by 
the 1a patch, it reported these problems:

Two classes referenced do not exist:
- org.apache.derby.impl.store.raw.log.SaveLWMOperation
- org.apache.derby.impl.sql.execute.ReplaceJarConstantAction

One class does not implement TypedFormat or InstanceGetter:
- org.apache.derby.iapi.util.ByteArray

We can probably remove the references to these classes as well.
                
> Remove non-Formatable classes from RegisteredFormatIds and StoredFormatIds
> --------------------------------------------------------------------------
>
>                 Key: DERBY-6168
>                 URL: https://issues.apache.org/jira/browse/DERBY-6168
>             Project: Derby
>          Issue Type: Improvement
>          Components: Services
>    Affects Versions: 10.11.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: d6168-1a-rts.diff, D6168.java
>
>
> RegisteredFormatIds and StoredFormatIds contain identifiers for classes that 
> implement the Formatable interfaces and are used when 
> serializing/deserializing instances of those classes.
> Many of the classes referenced there do however not implement Formatable. The 
> references to them could be removed. I've seen that many classes in the 
> impl.sql.execute.rts package are there, none of which implement Formatable. 
> There may be more.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to