[
https://issues.apache.org/jira/browse/DERBY-6195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rick Hillegas updated DERBY-6195:
---------------------------------
Attachment: derby-6195-01-aa-encapsulateBetter.diff
Attaching derby-6195-01-aa-encapsulateBetter.diff. This patch improves the
privacy of several classes in this package. I will run tests.
Touches the following files:
--------------------
M java/tools/org/apache/derby/impl/tools/ij/URLCheck.java
M java/tools/org/apache/derby/impl/tools/ij/ParseException.java
M java/tools/org/apache/derby/impl/tools/ij/ijResultSetResult.java
M java/tools/org/apache/derby/impl/tools/ij/ijMultipleResultSetResult.java
Reduce the visibility of the state variables from public to private. And/or
clone array args at construction and accessor time.
--------------------
M java/tools/org/apache/derby/impl/tools/build.xml
Reduce the generated ijConstants and ijTokenManager classes from public to
package visibility.
--------------------
M java/tools/org/apache/derby/iapi/tools/build.xml
A java/tools/org/apache/derby/iapi/tools/ToolUtils.java
New class which repeats the array-copying methods in
org.apache.derby.iapi.services.io.ArrayUtil. I would prefer to not have to
clone this code, but this seems to be what we're stuck with until we figure out
a way to share code across jar files.
> Cleanup suspect coding practices in the org.apache.derby.impl.tools.ij
> package.
> -------------------------------------------------------------------------------
>
> Key: DERBY-6195
> URL: https://issues.apache.org/jira/browse/DERBY-6195
> Project: Derby
> Issue Type: Bug
> Components: Tools
> Affects Versions: 10.11.0.0
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Priority: Minor
> Attachments: derby-6195-01-aa-encapsulateBetter.diff
>
>
> Similar to DERBY-6177.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
