[
https://issues.apache.org/jira/browse/DERBY-6206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rick Hillegas updated DERBY-6206:
---------------------------------
Attachment: derby-6206-04-aa-implJDBC.diff
Attaching derby-6206-04-aa-implJDBC.diff. This patch cleans up some mutability
issues in the org.apache.derby.impl.jdbc package. I will run tests.
The following changes are made:
1) Hide a globally visible field which was used to test the large update counts
introduced by JDBC 4.2. The field is made private and given a globally visible
set method. The set method is a NOP in insane builds and the test is changed to
only run on debug jars.
2) Copy the column descriptors which are passed to the constructor of the
embedded ResultSetMetaData class. This copying only happens when you make a
ResultSetMetaData object.
3) Copy the argument array when you ask an embedded SQLException for its
arguments.
Touches the following files:
--------------------
M java/engine/org/apache/derby/impl/sql/execute/DMLWriteResultSet.java
M java/engine/org/apache/derby/impl/sql/execute/RowUtil.java
M java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java
M
java/testing/org/apache/derbyTesting/functionTests/tests/jdbc4/StatementTest.java
M java/client/org/apache/derby/client/am/ClientStatement.java
Changes for (1).
--------------------
M java/engine/org/apache/derby/impl/jdbc/EmbedResultSetMetaData.java
Changes for (2).
--------------------
M java/engine/org/apache/derby/impl/jdbc/EmbedSQLException.java
Changes for (3).
> Cleanup suspect coding practices in misc Derby packages
> -------------------------------------------------------
>
> Key: DERBY-6206
> URL: https://issues.apache.org/jira/browse/DERBY-6206
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.11.0.0
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Priority: Minor
> Attachments: derby-6206-01-aa-NetworkServerControlImpl.diff,
> derby-6206-02-aa-ExecutionContext.diff, derby-6206-03-aa-XPLAIN.diff,
> derby-6206-04-aa-implJDBC.diff
>
>
> Similar to DERBY-6177.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
