[ 
https://issues.apache.org/jira/browse/DERBY-6169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645625#comment-13645625
 ] 

Knut Anders Hatlen commented on DERBY-6169:
-------------------------------------------

I haven't been able to come up with a test case that exercises the (now buggy) 
getProviderInfo() method yet. A comment in BasicDependencyManager indicates 
that it is only called if the view was created in a "previous version of server 
which doesn't support column dependency". That comment is also present in the 
10.0 code line, so I think it is very likely that it is part of some pre-Derby 
upgrade logic that is not needed anymore.
                
> Reduce visibility of classes and methods under impl/sql
> -------------------------------------------------------
>
>                 Key: DERBY-6169
>                 URL: https://issues.apache.org/jira/browse/DERBY-6169
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 10.11.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: derby-6169-01-a.diff, derby-6169-02-a.diff, 
> derby-6169-03-a.diff, derby-6169-04-a.diff, derby-6169-05-a.diff, 
> derby-6169-06-a.diff, derby-6169-06-b.diff, derby-6169-07-a.diff, 
> derby-6169-08-a.diff, derby-6169-09-a.diff
>
>
> My IDE shows many warnings in the classes under impl/sql because they are 
> public and may make parts of the internal state more visible than necessary. 
> I'd like to reduce the visibility of classes and methods, if possible, to 
> make it clearer to IDEs and tools that perform static analysis that the code 
> is only accessed from the same package, and reduce some of the noise from the 
> tools.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to