[ 
https://issues.apache.org/jira/browse/DERBY-6211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rick Hillegas updated DERBY-6211:
---------------------------------

    Attachment: derby-6211-04-aa-moveOptimizerTracerToEngineJar.diff

Attaching derby-6211-04-aa-moveOptimizerTracerToEngineJar.diff. This patch 
moves the OptimizerTracer optional tool out of the tools jar and into the 
engine jar. I am running tests now.

With this patch, the tools jar shrinks back to its old size. Hopefully this 
will address the sealing violations in the compatibility tests.

Touches the following files:

----------------

D       java/tools/org/apache/derby/impl/tools/optional/OptimizerTracer.java
A  +    java/engine/org/apache/derby/impl/sql/compile/OptimizerTracer.java
M       java/engine/org/apache/derby/impl/sql/build.xml
M       tools/jar/extraDBMSclasses.properties
M       tools/jar/tools.properties

Build changes for this move. I added a Java 6 build target to 
java/engine/org/apache/derby/impl/sql/build.xml because OptimizerTracer 
requires varargs in order to compile. We can rip out this new target when we 
deprecate support for Java 5 and CDC.

----------------

M       java/engine/org/apache/derby/catalog/Java5SystemProcedures.java

Look for OptimizerTracer in its new package.

----------------

M       java/tools/org/apache/derby/loc/toolsmessages.properties
M       java/engine/org/apache/derby/loc/messages.xml
M       java/shared/org/apache/derby/shared/common/reference/SQLState.java

Move some OptimizerTracer messages to the engine message file.

                
> Make Optimizer trace logic pluggable.
> -------------------------------------
>
>                 Key: DERBY-6211
>                 URL: https://issues.apache.org/jira/browse/DERBY-6211
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 10.11.0.0
>            Reporter: Rick Hillegas
>            Assignee: Rick Hillegas
>         Attachments: derby-6211-01-aa-createPlugin.diff, 
> derby-6211-02-aa-cleanup.diff, derby-6211-02-ab-cleanup.diff, 
> derby-6211-03-aa-customTracer.diff, 
> derby-6211-04-aa-moveOptimizerTracerToEngineJar.diff
>
>
> Right now the trace logic in the optimizer is hard-coded to produce a stream 
> of diagnostics. It would be good to be able to plug alternative trace logic 
> into the optimizer. This would make the following possible:
> 1) Plug in trace logic which produces formats which are easier to study and 
> which can be analyzed mechanically. E.g., xml formatted output.
> 2) Plug in trace logic which can be used during unit testing to verify that 
> the optimizer has picked the right plan. Over time this might make it easier 
> to migrate canon-based tests to assertion-based tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to