Actually, I think that is an important point, thx David...
I've been surprised about this test failing in a configuration with only db2jcc, i.e. no derby client, when there is never any reference to jcc in this test.
I think this test should indeed be *only* run with framework=DerbyNetClient, and thus, it should be listed only in derbynetclientmats.runall.
derbynetmats should list those tests that run with both frameworks.
Although we cannot require everyone to run tests with jcc, we do still need to support that framework - there are existing customers.
Myrna
On 11/8/05, Rick Hillegas <[EMAIL PROTECTED]> wrote:
Hi David,
Please feel free to move the compatibility test to the framework you prefer.
I apologize for the churn caused by moving files around. I second your
appeal for better patch technology.
-Rick
David W. Van Couvering wrote:
> Hi, Rick. I have (finally) been able to apply this patch. My
> goodness, moving files/directories is a bit if a nightmare with svn
> diff / patch. Did someone say there is a better patch program that
> can handle this?
>
> Is there a reason you are running the compatibility tests in
> derbynetmats suite? Shouldn't this be in derbynetclientmats?
> derbynetmats runs with the DB2 JDBC driver, which although interesting
> seems less important than the Derby JDBC driver.
>
> Thanks,
>
> David
>
>
> Rick Hillegas (JIRA) wrote:
>
>> [ http://issues.apache.org/jira/browse/DERBY-689?page=all ]
>>
>> Rick Hillegas updated DERBY-689:
>> --------------------------------
>>
>> Attachment: bug689.diff
>>
>> Various improvements to compatibility test:
>>
>> 1) Moved all JUnit tests under a ...functionTests/tests/junitTests as
>> Myrna and John requested.
>>
>> 2) Made the test harness sanity check the classpath as David requested.
>>
>> 3) Abstracted a CompatibilitySuite out of the original test to make
>> it easier to add more test classes, as Francois requested.
>>
>> 4) Added combinations for the 10.1.2.0 client and server
>>
>> 5) The derbyall diff tool was enhanced to fabricate an empty canon
>> file if one doesn't exist in the codeline. This eliminates the need
>> to create empty canons for JUnit tests.
>>
>> The svn status for this patch follows:
>>
>> M java\testing\README.htm
>> D
>> java\testing\org\apache\derbyTesting\functionTests\tests\compatibility
>> D
>> java\testing\org\apache\derbyTesting\functionTests\tests\compatibility\README.html
>>
>> D
>> java\testing\org\apache\derbyTesting\functionTests\tests\compatibility\testScript.xml
>>
>> D
>> java\testing\org\apache\derbyTesting\functionTests\tests\compatibility\Pinger.java
>>
>> D
>> java\testing\org\apache\derbyTesting\functionTests\tests\compatibility\JDBCDriverTest.java
>>
>> D
>> java\testing\org\apache\derbyTesting\functionTests\tests\compatibility\build.xml
>>
>> D
>> java\testing\org\apache\derbyTesting\functionTests\tests\jdbcapi\CompatibilityTest.java
>>
>> D
>> java\testing\org\apache\derbyTesting\functionTests\tests\jdbcapi\CompatibilityTest_app.properties
>>
>> M
>> java\testing\org\apache\derbyTesting\functionTests\tests\jdbcapi\copyfiles.ant
>>
>> A
>> java\testing\org\apache\derbyTesting\functionTests\tests\junitTests
>> A +
>> java\testing\org\apache\derbyTesting\functionTests\tests\junitTests\compatibility
>>
>> M +
>> java\testing\org\apache\derbyTesting\functionTests\tests\junitTests\compatibility\README.html
>>
>> M +
>> java\testing\org\apache\derbyTesting\functionTests\tests\junitTests\compatibility\testScript.xml
>>
>> A
>> java\testing\org\apache\derbyTesting\functionTests\tests\junitTests\compatibility\CompatibilitySuite.java
>>
>> M +
>> java\testing\org\apache\derbyTesting\functionTests\tests\junitTests\compatibility\Pinger.java
>>
>> M +
>> java\testing\org\apache\derbyTesting\functionTests\tests\junitTests\compatibility\JDBCDriverTest.java
>>
>> M +
>> java\testing\org\apache\derbyTesting\functionTests\tests\junitTests\compatibility\build.xml
>>
>> A
>> java\testing\org\apache\derbyTesting\functionTests\tests\junitTests\derbynet
>>
>> A +
>> java\testing\org\apache\derbyTesting\functionTests\tests\junitTests\derbynet\CompatibilityTest_app.properties
>>
>> A +
>> java\testing\org\apache\derbyTesting\functionTests\tests\junitTests\derbynet\CompatibilityTest.java
>>
>> A
>> java\testing\org\apache\derbyTesting\functionTests\tests\junitTests\derbynet\copyfiles.ant
>>
>> A
>> java\testing\org\apache\derbyTesting\functionTests\tests\junitTests\derbynet\build.xml
>>
>> M
>> java\testing\org\apache\derbyTesting\functionTests\harness\FileCompare.java
>>
>> D
>> java\testing\org\apache\derbyTesting\functionTests\master\CompatibilityTest.out
>>
>> M
>> java\testing\org\apache\derbyTesting\functionTests\suites\derbynetmats.runall
>>
>> M
>> java\testing\org\apache\derbyTesting\functionTests\util\DerbyJUnitTest.java
>>
>> M java\testing\build.xml
>>
>> Note that functionTests/tests/compatibility was svn moved to
>> functionTests/tests/junitTests/compatibility and the
>> CompatibiltiyTest itself was svn moved to
>> functionTests/tests/junitTests/derbynet.
>>
>> The compatibility test suite runs cleanly on my machine and so does
>> derbyall.
>>
>>
>>> Various improvements to compatibility test.
>>> -------------------------------------------
>>>
>>> Key: DERBY-689
>>> URL: http://issues.apache.org/jira/browse/DERBY-689
>>> Project: Derby
>>> Type: Improvement
>>> Reporter: Rick Hillegas
>>> Assignee: Rick Hillegas
>>> Attachments: bug689.diff
>>>
>>> Improve compatibility test as various reviewers requested.
>>
>>
>>
