[ 
https://issues.apache.org/jira/browse/DERBY-6231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13671277#comment-13671277
 ] 

Dag H. Wanvik commented on DERBY-6231:
--------------------------------------

Thanks! Looks like a good clean-up to me. I admit I didn't check all the 
changed lines in detail, but the approach gets my +1 :)

                
> Remove unnecessary checks for UnsupportedEncodingException in the client
> ------------------------------------------------------------------------
>
>                 Key: DERBY-6231
>                 URL: https://issues.apache.org/jira/browse/DERBY-6231
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>    Affects Versions: 10.11.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>             Fix For: 10.11.0.0
>
>         Attachments: derby-6231-01-a.diff
>
>
> Many methods in the client need handling of UnsupportedEncodingException, 
> typically because they call String methods that take the name of the encoding 
> as argument. Most of these methods have overloads that take a Charset instead 
> of a String to describe the encoding, and those methods don't throw 
> UnsupportedEncodingException as the encoding is known to be supported once we 
> have a Charset instance for it. We should use the methods that take a Charset 
> and simplify the exception handling.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to