[
https://issues.apache.org/jira/browse/DERBY-5553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13743726#comment-13743726
]
Knut Anders Hatlen commented on DERBY-5553:
-------------------------------------------
The fix and the test cases look good to me. You may want to change the comment
in updateDataSourceValues() so that it describes what the code does instead of
the symptoms of the fixed bug. For example something along these lines:
// Trace level and trace directory will be read from system
// properties if they are not specified in the Properties
// argument, so we check for them first to avoid getting cut
// off by the (prop == null) check below.
> System property for client tracing -Dderby.client.traceDirectory does not
> work with XADataSource
> ------------------------------------------------------------------------------------------------
>
> Key: DERBY-5553
> URL: https://issues.apache.org/jira/browse/DERBY-5553
> Project: Derby
> Issue Type: Bug
> Components: Network Client
> Affects Versions: 10.8.2.2, 10.9.1.0
> Reporter: Kathey Marsden
> Assignee: Kathey Marsden
> Labels: derby_triage10_11
> Attachments: derby-5553_codediff.txt, derby-5553_diff_withtests.txt,
> utilXid.java, XATemplate.java
>
>
> The client system property -Dderby.client.traceDirectory does not work with
> ClientXADataSource. No trace files are created if this property is set when
> making XA Connections.
> I am sure it works fine with DriverManager connections and also checked
> tracing works fine using connection attributes and XA with.
> ds.setConnectionAttributes("traceDirectory=./traceDir");
> I have not checked ClientDataSource or ClientConnectionPoolDataSource.
> Attached is a reproduction for this issue.
> mkdir ./traceDir
> javac -g XATemplate.java utilXid.java
> java -Dderby.client.traceDirectory="./traceDir" XATemplate
> You will see that traceDir is empty.
> This came up when debugging DERBY-5552
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
