[ 
https://issues.apache.org/jira/browse/DERBY-6350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782211#comment-13782211
 ] 

Brett Bergquist commented on DERBY-6350:
----------------------------------------

Manta, can you review the code in SingleStream.java, lines 261-278.   I tried 
to follow the model when using "derby.stream.error.method=xxx" fails.  So that 
code is throwing an IllegalArgumentException with the error message and 
catching the error (to get the stack traceback) and then calling 
useDefaultStream with the caught exception.

So I think this should be correct and should use the "derby.log" when you use 
an invalid "style".  From your IJ output earlier it looks like (with patch 6) 
that it output the error and continued.   

Also if you could review ErrorStreamTest.java, lines 393-408.   this is 
checking for an unknown style and checking to see if the errStreamFile is not 
empty.   Maybe this needs to also test the derby.log is not empty but this code 
was modeled on the "testWrongMethod" test in the same file.

> Provide a rolling file implementation of derby.log
> --------------------------------------------------
>
>                 Key: DERBY-6350
>                 URL: https://issues.apache.org/jira/browse/DERBY-6350
>             Project: Derby
>          Issue Type: Improvement
>          Components: Miscellaneous
>            Reporter: Brett Bergquist
>            Priority: Minor
>              Labels: features
>         Attachments: rollingfilelog.patch.txt, rollingfilelog.patch.txt, 
> rolling_file_patch_5.txt, rolling_file_patch_6.txt
>
>
> By default, derby.log grows without bounds if the derby.infolog.append 
> property is set to "true".   Setting this to "true" helps in a hands off 
> production environment to ensure that if Derby restarts, the derby.log which 
> might contain important information is not lost.  On the other hand, when set 
> the "true" the derby.log grows without bounds.  This is problematic in a long 
> running system.  
> What is really needed is the ability to have a rolling derby.log file support 
> where the maximum file size and maximum number of files can be specified.  
> Derby has the ability to configure the location of the log file (ie. 
> derby.stream.error.file) and also two methods of redirecting the error stream 
> (.ie derby.stream.error.method and derby.stream.error.field).  There is no 
> standard implementation that supports a rolling derby.log however.
> This facility should be part of the core Derby system so that it works in 
> both embedded and network server models.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to