[ 
https://issues.apache.org/jira/browse/DERBY-6376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13792668#comment-13792668
 ] 

Knut Anders Hatlen commented on DERBY-6376:
-------------------------------------------

Thanks, Kim. This looks like a good new structure for these topics. +1 to 
commit.

I'm not sure the original descriptions of the COLUMN_TYPE and NULLABLE columns 
are completely accurate. For example, COLUMN_TYPE doesn't mention 
procedureColumnOut, although Derby supports OUT parameters. Additionally, it 
talks about procedureColumnReturn for return values, but I don't think Derby 
supports return values from procedures, see DERBY-2927. And for NULLABLE, I'm 
wondering if it perhaps may (or at least should) be functionNullable also for 
primitive parameters if a function is declared as RETURNS NULL ON NULL INPUT.

I'll run some experiments and get back to you on that. But don't let that stop 
you from committing the current patch as it is.

> Revise DatabaseMetaData section of Reference Manual
> ---------------------------------------------------
>
>                 Key: DERBY-6376
>                 URL: https://issues.apache.org/jira/browse/DERBY-6376
>             Project: Derby
>          Issue Type: Improvement
>          Components: Documentation
>    Affects Versions: 10.10.1.1
>            Reporter: Kim Haase
>            Priority: Minor
>         Attachments: DERBY-6376.diff, DERBY-6376.stat, DERBY-6376.zip
>
>
> In a comment on DERBY-6369, Knut Anders Hatlen suggests that the topic 
> "Parameters to getProcedureColumns" 
> (http://db.apache.org/derby/docs/10.10/ref/rrefpgc1.html) might be removed. 
> The purpose of the topics under "JDBC Reference" is to provide Derby-specific 
> implementation information. In this topic, however, the Derby-specific 
> information seems to apply to other methods as well: the information on 
> catalogs and the information on name patterns.
> It may be that another topic in the same section, 
> "java.sql.DatabaseMetaData.getProcedureColumns method" 
> (http://db.apache.org/derby/docs/10.10/ref/rrefgpc1.html), could also be 
> removed. Derby presumably supports other DatabaseMetaData methods that are 
> not mentioned, such as getFunctionColumns and, more recently, getAttributes 
> (of UDTS) and getUDTs. Why mention this one only?
> The topic "Columns in the ResultSet returned by getProcedureColumns" 
> (http://db.apache.org/derby/docs/10.10/ref/rrefcrsrgpc1.html) does contain 
> Derby-specific information, listing a couple of columns that are not listed 
> in the Java SE documentation on this method (see 
> http://docs.oracle.com/javase/7/docs/api/java/sql/DatabaseMetaData.html). So 
> this topic needs to be retained.
> Some information could be added to the top-level "java.sql.DatabaseMetaData 
> interface" topic 
> (http://docs.oracle.com/javase/7/docs/api/java/sql/DatabaseMetaData.html) 
> about needing to specify null for catalog columns and perhaps about using the 
> "%" wildcard to obtain a list of all items in a particular namePattern field.
> Let me know if these changes don't make sense.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to