[
https://issues.apache.org/jira/browse/DERBY-5125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Anders Hatlen updated DERBY-5125:
--------------------------------------
Attachment: javacc6.diff
Attaching an updated patch, javacc6.diff, that makes the required changes to
get it working with JavaCC 6.0.
Unfortunately, we still see the sub-optimal error messages that we saw with
JavaCC 5.0.
The changes relative to the javacc5.diff patch are as follows:
- Changed JDK_VERSION to 1.6 in the grammar files, since that's the minimum
level on trunk now.
- Removed ij's custom CharStream implementation
impl/tools/ij/UCode_CharStream.java and instead let it use the generated
SimpleCharStream class. This change was needed because some new methods had
been added to the CharStream interface, and those methods were not implemented
by ij's custom class. (The alternative was to implement those methods in
UCode_CharStream.java. I wasn't able to see that any customizations had been
made, so it sounded like a better option to use the default, automatically
generated class.)
- Updated the ij build script to reduce the visibility of the SimpleCharStream
class (like it already does with the ijConstants interface and the
ijTokenManager class) since that class is now included in derbytools.jar and
doesn't need to be public.
> Derby 10.7.1.1 : Build fails with javacc 5 (for Debian packaging)
> -----------------------------------------------------------------
>
> Key: DERBY-5125
> URL: https://issues.apache.org/jira/browse/DERBY-5125
> Project: Derby
> Issue Type: Improvement
> Components: Build tools
> Affects Versions: 10.7.1.1
> Environment: Debian Linux Linux inf-7590.int-evry.fr 2.6.32-5-amd64
> #1 SMP Wed Jan 12 03:40:32 UTC 2011 x86_64 GNU/Linux
> java -version (also tested with sun jvm)
> java version "1.6.0_18"
> OpenJDK Runtime Environment (IcedTea6 1.8.7) (6b18-1.8.7-2)
> OpenJDK 64-Bit Server VM (build 16.0-b13, mixed mode)
> ant -version
> Apache Ant version 1.8.0 compiled on March 11 2010
> Reporter: Zied ABID
> Labels: build, libtool
> Fix For: 10.7.1.1, 10.7.1.4, 10.8.2.2, 11.0.0.0
>
> Attachments: ParseGen.diff, d5125-javacc5-and-tests-2.diff,
> d5125-javacc5-and-tests.diff, derby-5125-parseException.diff,
> derby-5125-sqlParser.diff, javacc5.diff, javacc6.diff
>
>
> I try to and Apache derby into Debian, so I begin to compile derby
> sources [1], derby sources provide each own libs and javacc is one of
> them. In Debian, javacc version is 5.0 [2].
> After some tries, I'm in a this situation : compilation success with the
> official [3] javacc 4.0 and fail with the 5.0 official one.
> I think that is related with javacc options passed in .jj files
> (ex. java/engine/org/apache/derby/impl/sql/compile/sqlgrammar.jj lines 2-14)
> I don't know much about javacc, so I can't resolve unless modifying
> options blindly and I'm afraid that isn't enough ...
> Best regards,
> Zied
> [1] http://svn.apache.org/repos/asf/db/derby/code/tags/10.7.1.1/
> [2] http://packages.debian.org/squeeze/javacc
> [3] http://java.net/projects/javacc/downloads
--
This message was sent by Atlassian JIRA
(v6.1#6144)
