[ 
https://issues.apache.org/jira/browse/DERBY-6380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Myrna van Lunteren updated DERBY-6380:
--------------------------------------

    Attachment: DERBY-6380.diff

Attaching a patch, which creates the files created for all tests in a 
subdirectory, logfiles, and overrides the BasetTestCase.runBareOverrides class 
(as suggested in the comments) to copy this directory in its entirety when a 
test fails.

I looked at modifying the creation of derby.log, but it's happening at a quite 
early time in the test process, and I think it gets created for any test. So 
I've left that alone.

Also, this test creates a number of other files, but some of the individual 
test cases specifically verify that they can be deleted afterwards, so I could 
not come up with an efficient way to copy those when the test fails.

Patch ready for review.

> Rolling log files do not get copied in failed directory when a junit test 
> fails
> -------------------------------------------------------------------------------
>
>                 Key: DERBY-6380
>                 URL: https://issues.apache.org/jira/browse/DERBY-6380
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>    Affects Versions: 10.11.0.0
>            Reporter: Mamta A. Satoor
>         Attachments: DERBY-6380.diff
>
>
> DERBY-6350(Provide a rolling file implementation of derby.log) is adding a 
> very useful feature to Derby. To test the feature, I ran the junit suite with 
> rollingFile option as shown below
> time java -Dderby.stream.error.style=rollingFile -Dderby.tests.trace=true 
> junit.textui.TestRunner org.apache.derbyTesting.functionTests.suites.All > 
> runall.out 2>&1
> I noticed that even though we are running junit suite with the rollingFile, 
> we still create derby.log(although it was empty) along with expected 
> derby-0.log and so on. I had not expected to see the traditional derby.log 
> when running with rollingFile. In addition, when a test failed, the failed 
> directory had empty derby.log copied but the rolling log files did not get 
> copied. The code changes to copy the rolling log files in case of failure 
> probably need to go into org.apache.derbyTesting.junit.BaseTestCase:runBare() 
> in the "catch (Throwable running) {" section. The log files are crucial to do 
> any test failure debugging and hence should get copied in the failed 
> directory.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to