[
https://issues.apache.org/jira/browse/DERBY-6380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13833511#comment-13833511
]
Myrna van Lunteren commented on DERBY-6380:
-------------------------------------------
I ran suites.All with and without my patch, and the run without was about 20
seconds faster (over 3 1/2 hours), which I think is not significant. So I
committed, which should address the basic concern of this issue.
Note that it's only the default log file names (derby-[0-9].log) that show up
when running full suites.All with -Dderby.error.stream.style=logFile.
The caveats for the ErrorStreamTest still hold; the only files copied on fail
are now the ones created in the setUp methods, because the fixtures themselves
test the removal of other files created in those fixtures.
> Rolling log files do not get copied in failed directory when a junit test
> fails
> -------------------------------------------------------------------------------
>
> Key: DERBY-6380
> URL: https://issues.apache.org/jira/browse/DERBY-6380
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.11.0.0
> Reporter: Mamta A. Satoor
> Attachments: DERBY-6380.diff, DERBY-6380.diff_2
>
>
> DERBY-6350(Provide a rolling file implementation of derby.log) is adding a
> very useful feature to Derby. To test the feature, I ran the junit suite with
> rollingFile option as shown below
> time java -Dderby.stream.error.style=rollingFile -Dderby.tests.trace=true
> junit.textui.TestRunner org.apache.derbyTesting.functionTests.suites.All >
> runall.out 2>&1
> I noticed that even though we are running junit suite with the rollingFile,
> we still create derby.log(although it was empty) along with expected
> derby-0.log and so on. I had not expected to see the traditional derby.log
> when running with rollingFile. In addition, when a test failed, the failed
> directory had empty derby.log copied but the rolling log files did not get
> copied. The code changes to copy the rolling log files in case of failure
> probably need to go into org.apache.derbyTesting.junit.BaseTestCase:runBare()
> in the "catch (Throwable running) {" section. The log files are crucial to do
> any test failure debugging and hence should get copied in the failed
> directory.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
