[ http://issues.apache.org/jira/browse/DERBY-706?page=all ]
Deepa Remesh updated DERBY-706:
-------------------------------
Attachment: derby-706.diff
derby-706.status
Attaching first patch 'derby-706.diff' for this. This patch adds some tests for
network server and re-arranges/removes some internal methods which are not
used. Details of patch are:
* derbynet/getCurrentProperties.java - Added tests for
NetworkServerControl.logConnections and setTraceDirectory methods. Modified
getCurrentProperties_sed.properties to use a substitute instead of delete for
traceDirectory.
* derbynet/testProperties.java - Added some more command line tests.
* derbynet/timeslice.java and maxthreads.java - Added tests for invalid values.
* derbynet/runtimeinfo.java and sysinfo.java - Added test to call methods in
NetworkServer control
* Modified master files.
* DRDAResultSet.java - removed unused constructor "DRDAResultSet(ResultSet rs)"
* DRDAStatement.java - Changed getNumRsCols() to use getRsDRDATypes() instead
of directly calling DRDAResultSet method. Removed isProcedure() method which is
not used. Changed getResultSetCursorName() to call
drdaRs.getResultSetCursorName() which handles case for null result set.
* NetworkServerControlImpl.java - Removed methods for connection pooling which
is not implemented and not used.
With this patch, I ran derbyall with Sun JDK 1.4.2. No failures. Please
review/commit this patch.
> Improve testing and increase code coverage for Network Server classes
> ---------------------------------------------------------------------
>
> Key: DERBY-706
> URL: http://issues.apache.org/jira/browse/DERBY-706
> Project: Derby
> Type: Improvement
> Components: Test
> Versions: 10.2.0.0
> Reporter: Deepa Remesh
> Assignee: Deepa Remesh
> Priority: Minor
> Attachments: derby-706.diff, derby-706.status
>
> Improve testing of network server by increasing tests to cover 100% of the
> classes and increase the method level coverage. The current code
> coverage(class/method) for network server based on svn revision 208786 are:
> org.apache.derby.drda.NetworkServercontrol.java - 100/72
> org.apache.derby.impl.drda - 97/78
> Details of code coverage from EMMA tool are available from Derby Wiki. Links
> are:
> http://wiki.apache.org/db-derby/CodeCoverage
> http://people.apache.org/~fuzzylogic/codecoverage/208786/_files/c5.html
> http://people.apache.org/~fuzzylogic/codecoverage/208786/_files/25.html
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
