[
http://issues.apache.org/jira/browse/DERBY-706?page=comments#action_12358423 ]
Kathey Marsden commented on DERBY-706:
--------------------------------------
I committted this change.
My only comment is that for setMaxThreads/setTimeSlice I think that we need
to make sure that the functionality is tested in addition to adding the api
call. I don't think there are any tests that currently test that the timeslice
is working properly.
In addition to the fact that we don't have tests for this I once noticed
something in CllientThread and put a comment in the code but never actually
filed a bug, but it makes me think that there might be a problem with
setTimeSlice.
//this looks highly suspect. Why does
timeSlice setSoTimeout?
if (timeSlice != 0)
clientSocket.setSoTimeout(timeSlice);
Let me know if you want input on how to test this.
> Improve testing and increase code coverage for Network Server classes
> ---------------------------------------------------------------------
>
> Key: DERBY-706
> URL: http://issues.apache.org/jira/browse/DERBY-706
> Project: Derby
> Type: Improvement
> Components: Test
> Versions: 10.2.0.0
> Reporter: Deepa Remesh
> Assignee: Deepa Remesh
> Priority: Minor
> Attachments: derby-706.diff, derby-706.status
>
> Improve testing of network server by increasing tests to cover 100% of the
> classes and increase the method level coverage. The current code
> coverage(class/method) for network server based on svn revision 208786 are:
> org.apache.derby.drda.NetworkServercontrol.java - 100/72
> org.apache.derby.impl.drda - 97/78
> Details of code coverage from EMMA tool are available from Derby Wiki. Links
> are:
> http://wiki.apache.org/db-derby/CodeCoverage
> http://people.apache.org/~fuzzylogic/codecoverage/208786/_files/c5.html
> http://people.apache.org/~fuzzylogic/codecoverage/208786/_files/25.html
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
