[
https://issues.apache.org/jira/browse/DERBY-5133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996310#comment-13996310
]
Knut Anders Hatlen commented on DERBY-5133:
-------------------------------------------
The tearDown() method looks a bit odd. For example, this line contains a syntax
error (should have used double quotes instead of single quotes):
{code}
stmt.executeUpdate("drop table 'platypus2'");
{code}
The tearDown() method seems to give up dropping tables the first time it finds
one of the tables doesn't exist. Since the different test cases create
different sets of tables, I think there needs to be a try/catch block around
each single DROP TABLE statement, not one big try/catch block around all of
them as there currently is. Otherwise, it won't drop all tables as intended
(and I'm assuming that's also why the syntax error mentioned above wasn't
detected). Using the helper method dropTable() in BaseJDBCTestCase would give
you this for free.
The comment for checkSpaceTable() says it will sleep a bit before retrying, but
I can't see that it actually sleeps. Is it missing a call to
BaseTestCase.sleep()?
Instead of duplicating JDBC.assertFullResultSet(), would it be possible to base
assertSpaceTableOK() on just calling JDBC.assertFullResultSet()? Something
along the lines of:
{code}
try {
JDBC.assertFullResultSet(rs, expRS);
} catch (AssertionFailedError e) {
if (trytwice) {
sleep(x);
assertSpaceTableOK(tableName, expRS, false);
} else {
throw e;
}
}
{code}
> nightly test failure in derbyall/storeall/storemore/SpaceTable
> --------------------------------------------------------------
>
> Key: DERBY-5133
> URL: https://issues.apache.org/jira/browse/DERBY-5133
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.8.1.2
> Environment: derbyall fail
> *************************************************************
> derbyall/storeall/storeall.fail:store/SpaceTable.sql
> derbyall fail *************************************************************
> Generating report for RunSuite derbyall null null null true
> ------------------ Java Information ------------------
> Java Version: 1.4.2_02
> Java Vendor: Sun Microsystems Inc.
> Java home: /usr/local/java/j2sdk1.4.2_02/jre
> Java classpath:
> /export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/test/jet.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/derbyLocale_ru.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/derbyLocale_ja_JP.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/derbyLocale_hu.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/derbyrun.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/derbynet.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/derby.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/derbyLocale_cs.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/derbyTesting.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/derbyLocale_it.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/derbyLocale_zh_CN.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/derbytools.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/derbyLocale_pt_BR.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/derbyLocale_es.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/derbyLocale_ko_KR.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/derbyLocale_de_DE.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/derbyLocale_fr.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/derbyclient.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/derbyLocale_zh_TW.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/derbyLocale_pl.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/test/jakarta-oro-2.0.8.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/test/jmx.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/test/Perfmon.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/test/jetapi.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/test/db2jcc_license_c.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/test/emma_ant.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/test/javadbtests.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/test/GenCfg.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/test/emma.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/test/jmxremote.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/test/jmxremote_optional.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/test/javadbtesttools.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/test/mail.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/test/junit.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/test/jdmkrt.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/test/Dots.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/test/commons-logging.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/test/db2jcc.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/test/jagops.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/test/hadbjdbc4.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/test/jag.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/test/jetbatch.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/test/activation.jar:/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/test/dbprocedures.jar:
> OS name: Linux
> OS architecture: i386
> OS version: 2.6.18-53.1.14.el5
> Java user name: jaguser
> Java user home: /home/jaguser
> Java user dir: /export/home/tmp/jagtmp/autoderbyN_derbyall/derbyall_0/log
> java.specification.name: Java Platform API Specification
> java.specification.version: 1.4
> java.runtime.version: 1.4.2_02-b03
> --------- Derby Information --------
> JRE - JDBC: J2SE 1.4.2 - JDBC 3.0
> [/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/derby.jar] 10.8.0.1
> alpha - (1081468)
> [/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/derbytools.jar]
> 10.8.0.1 alpha - (1081468)
> [/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/derbynet.jar]
> 10.8.0.1 alpha - (1081468)
> [/export/home/tmp/jagtmp/autoderbyN_derbyall/install/lib/derbyclient.jar]
> 10.8.0.1 alpha - (1081468)
> ------------------------------------------------------
> ----------------- Locale Information -----------------
> Current Locale : [English/United States [en_US]]
> Found support for locale: [cs]
> version: 10.8.0.1 alpha - (1081468)
> Found support for locale: [de_DE]
> version: 10.8.0.1 alpha - (1081468)
> Found support for locale: [es]
> version: 10.8.0.1 alpha - (1081468)
> Found support for locale: [fr]
> version: 10.8.0.1 alpha - (1081468)
> Found support for locale: [hu]
> version: 10.8.0.1 alpha - (1081468)
> Found support for locale: [it]
> version: 10.8.0.1 alpha - (1081468)
> Found support for locale: [ja_JP]
> version: 10.8.0.1 alpha - (1081468)
> Found support for locale: [ko_KR]
> version: 10.8.0.1 alpha - (1081468)
> Found support for locale: [pl]
> version: 10.8.0.1 alpha - (1081468)
> Found support for locale: [pt_BR]
> version: 10.8.0.1 alpha - (1081468)
> Found support for locale: [ru]
> version: 10.8.0.1 alpha - (1081468)
> Found support for locale: [zh_CN]
> version: 10.8.0.1 alpha - (1081468)
> Found support for locale: [zh_TW]
> version: 10.8.0.1 alpha - (1081468)
> Reporter: Mike Matrigali
> Labels: derby_triage10_10
> Attachments: DERBY-5133.diff
>
>
> http://dbtg.foundry.sun.com/derby/test/Daily/jvm1.4/testing/testlog/lin/1081468-derbyall_diff.txt
> Failure Details:
> ********* Diff file derbyall/storeall/storemore/SpaceTable.diff
> *** Start: SpaceTable jdk1.4.2_02 storeall:storemore 2011-03-15 11:50:03 ***
> 145 del
> < PLATYPUS
> |0 |1
> |20 |4096 |81920
> 145a145
> > PLATYPUS
> > |0 |2
> > |19 |4096 |77824
> Test Failed.
> *** End: SpaceTable jdk1.4.2_02 storeall:storemore 2011-03-15 11:50:13 ***
> ------------------------------------------------------
--
This message was sent by Atlassian JIRA
(v6.2#6252)
