[ 
https://issues.apache.org/jira/browse/DERBY-6639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14044582#comment-14044582
 ] 

ASF subversion and git services commented on DERBY-6639:
--------------------------------------------------------

Commit 1605738 from [~dagw] in branch 'code/trunk'
[ https://svn.apache.org/r1605738 ]

DERBY-6638 Remove unnecessary use of reflection in SignatureChecker

Remove the reflection + some missing javadocs and IDE warning fixes.

Removes unused argument from method "checkSignature", and changes all
StringBuilder usage to avoid concatenation.

I tested the tool manually for a simple case, but see DERBY-6639.

> Add tests for SignatureChecker
> ------------------------------
>
>                 Key: DERBY-6639
>                 URL: https://issues.apache.org/jira/browse/DERBY-6639
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test, Tools
>            Reporter: Dag H. Wanvik
>
> Fixed a code issue in SignatureChecker I noticed that we have no tests for 
> that tool (as far as I can see). It would be good to add some.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to