[
https://issues.apache.org/jira/browse/DERBY-6634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Anders Hatlen updated DERBY-6634:
--------------------------------------
Attachment: d6634-3a-impossible-paths.diff
Attaching [^d6634-3a-impossible-paths.diff] which removes some code paths that
seem to be impossible to reach:
- serializeToString(): Remove check for the items argument being null. All
callers pass in a non-null List object. By removing the check, we prevent
potential bugs from going unnoticed (they'll be reported as NPE instead of
being ignored).
- serializeToString(): Remove code that serializes a list of atomic values. The
only possible input to the method is a single atomic value or a list of
document nodes. There's no need for the extra complexity to handle lists of
atomic values, so remove it.
- serializeToString(): Remove check for the xmlVal argument being null. If
xmlVal is null where the check is, there is a bug, and reporting it as NPE is
better than ignoring it.
The regression tests ran cleanly with the patch.
> Improve test coverage of SqlXmlUtil.java
> ----------------------------------------
>
> Key: DERBY-6634
> URL: https://issues.apache.org/jira/browse/DERBY-6634
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Affects Versions: 10.11.0.0
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Minor
> Attachments: d6634-1a-dead-code.diff, d6634-2a-more-tests.diff,
> d6634-3a-impossible-paths.diff
>
>
> The test coverage report for SqlXmlUtil indicates that we don't have tests
> for:
> - recompilation of XML queries used in triggers (the code looks dead, and can
> probably be removed)
> - serialization of sequences of atomic values returned by an XPath query (as
> far as I can see, we only support single atomic values and sequences of
> documents, so probably that's also code that can be removed, possibly
> replaced by an assert)
> - XMLEXISTS operations where the XPath query returns a scalar (after
> DERBY-6624, it will take the same code path as a query that returns a
> non-empty sequence, so it won't show up in the report anymore, but it's still
> useful to have a test case for it)
> - XMLQUERY operations where the XPath query returns a boolean (after
> DERBY-6624, the same code path will be taken for all data types, so it won't
> show up in the report anymore, but it's still useful to have a test case for
> it)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
