[
https://issues.apache.org/jira/browse/DERBY-6642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14048678#comment-14048678
]
Knut Anders Hatlen commented on DERBY-6642:
-------------------------------------------
Looks fine to me. +1
Nit 1: Double semicolon in addRsToReport():
{code}
seenRow.clear();;
{code}
Nit 2: The inner for loop in addRsToReport() could probably be replaced with
row.toString(). (You'd get square brackets instead of curly ones, though.)
> Make the JUnit result set assertion methods dump the actual rs when assertion
> fails
> -----------------------------------------------------------------------------------
>
> Key: DERBY-6642
> URL: https://issues.apache.org/jira/browse/DERBY-6642
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Dag H. Wanvik
> Attachments: derby-6642.diff
>
>
> Often, when researching intermittent regression test errors, an assertion on
> a result set fails, but the error report only shows which column in which row
> first fails to meet expectations. It would be good if the assertion methods
> could dump the actual result set in such cases so we'd have more information
> to go on when trying to understand the cause of the problem.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
