[
https://issues.apache.org/jira/browse/DERBY-6674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089347#comment-14089347
]
ASF subversion and git services commented on DERBY-6674:
--------------------------------------------------------
Commit 1616511 from [~dagw] in branch 'code/branches/10.11'
[ https://svn.apache.org/r1616511 ]
DERBY-6674 Cleanup brittle code in ValidateCheckConstraintResultSet
Backport from trunk as
svn merge -c 1614963 https://svn.apache.org/repos/asf/db/derby/code/trunk
Patch derby-6674. Refactors the code by reusing getNextRowCore (to
avoid the redundancy) for ValidateCheckConstraintResultSet but
abstracting out the loop control, which is overridden by
ValidateCheckConstraintResultSet.
> Cleanup brittle code in ValidateCheckConstraintResultSet
> --------------------------------------------------------
>
> Key: DERBY-6674
> URL: https://issues.apache.org/jira/browse/DERBY-6674
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 10.11.1.1
> Reporter: Rick Hillegas
> Assignee: Dag H. Wanvik
> Fix For: 10.11.1.1
>
> Attachments: derby-6674.diff
>
>
> The getNextRowCore() method of ValidateCheckConstraintResultSet is an almost
> exact cut-and-paste copy of the method it overrides in its superclass. This
> code should be re-factored to reduce the cut-and-paste brittleness. This was
> discovered while investigating DERBY-6665.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
