[ 
https://issues.apache.org/jira/browse/DERBY-6751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159692#comment-14159692
 ] 

Knut Anders Hatlen commented on DERBY-6751:
-------------------------------------------

I took a quick look in a profiler. The one thing that caught my attention, was 
that ConnectionChild.getLanguageConnectionContext(EmbedConnection) (called from 
EmbedResultSet.movePosition()) came fairly high up. It is called once per call 
to ResultSet.next(). The test in question works on relatively big result sets 
(1000 rows), so it makes sense that its performance is affected when 
doPrivileged() is called for every call to next(). Perhaps the lcc could be 
cached in EmbedResultSet to avoid the extra cost.

> Prevent user code from getting the LanguageConnectionContext from an 
> EmbedConnection
> ------------------------------------------------------------------------------------
>
>                 Key: DERBY-6751
>                 URL: https://issues.apache.org/jira/browse/DERBY-6751
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 10.12.0.0
>            Reporter: Rick Hillegas
>            Assignee: Rick Hillegas
>              Labels: derby_backport_reject_10_11
>             Fix For: 10.12.0.0
>
>         Attachments: derby-6751-01-aa-usederbyinternals.diff, 
> derby-6751-01-ab-usederbyinternals.diff, 
> derby-6751-01-ad-usederbyinternals.diff
>
>
> User code can cast a java.sql.Connection to an EmbedConnection and then get 
> the LanguageConnectionContext by calling 
> EmbedConnection.getLanguageConnection(). We should prevent user code from 
> doing this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to