> The changes you suggested fixes the Derby5578 test. I've changed the > return type of examineTriggerNode to int[] and I've run quite a > few test suites without encountering any bugs.
Wonderful! > The problem that I was facing while running the tests suites was > because of the "junit-html" in the command for executing tests suites, > it was causing the tests to fail, so I couldn't find a solution > to fix this and I ran the tests without it. Interesting. I haven't seen this problem, but I confess I don't use the 'junit-html' target all that often. I'm glad you were able to determine the cause of the probelm and avoid it for now. > Is there anything else that needs to be done before this patch is accepted ? I will spend some time with your final patch this weekend. Perhaps others are reviewing it too, I don't know. It sounds like we are ready to move forward with it, though, which is great news. Perhaps while I am studying the patch, you can return to DERBY-6773, which we haven't had time to work on recently, and see if you can pick up from where we left off? Thanks again for all the hard work on DERBY-6783. I think this is very nice work and it represents a substantial improvement to the trigger functionality in DERBY. bryan
