[ 
https://issues.apache.org/jira/browse/DERBY-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Pendleton updated DERBY-6801:
-----------------------------------
    Attachment: build.out

Hi Abhinav, thanks for the latest patch.

The code looks much cleaner now, this is great progress!

I am still seeing some compile errors on my machine; I attached
the file 'build.out' which shows what happens when I run 'ant all'
on a clean sandbox with the patch applied.

I hope to have some time this weekend to dig into your patch
in more detail, and then I can give you more substantial
feedback, but hopefully this is enough to give you something
to look at.

> Implement MessageUtils class so client and server can share message argument 
> encoding/decoding
> ----------------------------------------------------------------------------------------------
>
>                 Key: DERBY-6801
>                 URL: https://issues.apache.org/jira/browse/DERBY-6801
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client, Network Server
>            Reporter: Bryan Pendleton
>            Assignee: Abhinav Gupta
>            Priority: Minor
>         Attachments: build.out, messageUtils.diff, messageUtils_1.diff, 
> subPart2.diff
>
>
> Currently, the Network Server contains code which encodes message arguments 
> to be passed over DRDA to the client, and other code which
> decodes the encoded message arguments when the client passes
> them back in a call to SQLCAMESSAGE (see DERBY-1178 for additional
> discussion of this behavior).
> We would like to extract that logic and place it into a new MessageUtils
> class in the common shared library so that both the client and server
> can manipulate the message arguments without duplicating the code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to