Hi,
Thank you for pointing this out Dag. You have pointed out the following
issues
1) JDBC4.0 compilation target does not echo anything about the number of
files printed
2) Upon inserting a bug and setting proceed=false the compilation
proceeds instead of failing
I have fixed this in addition to a small change documented below
a) Removing the -quiet option
b) Setting failonerror depending on the value of the proceed variable
c) Removing the echo task since if the exec task fails we would want
the user to know the reason for failure which otherwise wouldnt be
printed if echo occurred after the exec task
d) I am also removing the part of the build which checks os and sets
executable to ant or ant.bat and am instead using vmlauncher attribute
of the exec task and am setting it to false.
I am attaching the patch to this email. Would you want me to raise a
JIRA issue for this and attach it to that?
thanx
V.Narayanan
Dag H. Wanvik wrote:
> Hi,
>
>
>>>>>>"V" == V Narayanan <[EMAIL PROTECTED]> wrote:
>
>
> V> can you please confirm that the compilation was done with jdk16
> V> variable in ant.properties pointing to mustang home. The
> V> ClientPooledConnection40.java gets compiled only with this variable
> V> included. thanx V.Narayanan
>
> I trid to compile with Mustang and it worked for me. I notice,
> however, that the jdbc4 target did not echo anything about number of
> files compiled, as does the ordinary compilation. Then, when I
> inserted a bug in a file (CallableStatement40.java), the build
> proceeded in spite of my setting proceed=false in ant.propeties. The
> build eventually reported BUILD SUCCEEDED, although the JDBC4 build
> failed. This seems to be a bug, unless something is wrong with my
> setup?
>
> Thanks,
>
> Dag
>
Index: build.xml
===================================================================
--- build.xml (revision 356991)
+++ build.xml (working copy)
@@ -1368,20 +1368,18 @@
<!-- Contains the ant-spawing logic -->
<property environment="env"/>
- <condition property="antExecutable" value="ant.bat">
- <os family="windows"/>
- </condition>
- <property name="antExecutable" value="ant"/>
+ <condition property="foe" value="true">
+ <isfalse value="${proceed}"/>
+ </condition>
+ <property name="foe" value="false"/>
- <exec executable="${env.ANT_HOME}/bin/${antExecutable}" outputproperty="jdbc4.output">
+ <exec executable="${env.ANT_HOME}/bin/ant" failonerror="${foe}" vmlauncher="false">
<env key="JAVA_HOME" value="${jdk16}"/>
- <arg value="-quiet"/>
<arg value="-f"/>
<arg path="${coj.buildscript}"/>
<arg value="${coj.target}"/>
</exec>
- <echo message="${jdbc4.output}"/>
</target>
