Hi Bryan, Your notes were very helpful for me to understand how we want to implement getArgs() and how it would be called. I've attached a patch to 6801 that tries to achieve this. In this patch I've also refactored SQLCAMESSAGE() of SystemProcedure but I've commented it for the moment, since I'm still a bit unsure about this particular piece of code.
Another issue that I noticed was that getArgs() also needs to return the messageId. One of the possible solutions that I could think of was to include the messageId field as the last object of the Object array arguments and retrieve it from there in getLocalizedMessage(). Would it be a good idea ? On Mon, Jul 27, 2015 at 5:10 AM, Abhinav Gupta (JIRA) <[email protected]> wrote: > > [ > https://issues.apache.org/jira/browse/DERBY-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > ] > > Abhinav Gupta updated DERBY-6801: > --------------------------------- > Attachment: MessageUtils_Latest_1.diff > > > Implement MessageUtils class so client and server can share message > argument encoding/decoding > > > ---------------------------------------------------------------------------------------------- > > > > Key: DERBY-6801 > > URL: https://issues.apache.org/jira/browse/DERBY-6801 > > Project: Derby > > Issue Type: Sub-task > > Components: JDBC, Network Client, Network Server > > Reporter: Bryan Pendleton > > Assignee: Abhinav Gupta > > Priority: Minor > > Attachments: MessageUtilsBryan.diff, MessageUtils_2.diff, > MessageUtils_3.diff, MessageUtils_Latest.diff, MessageUtils_Latest_1.diff, > MessageUtils_StandardEx_1.diff, MessageUtils_StandardExcep.diff, build.out, > messageUtils.diff, messageUtils_1.diff, subPart2.diff, > unsealDerbyNetJar.diff > > > > > > Currently, the Network Server contains code which encodes message > arguments to be passed over DRDA to the client, and other code which > > decodes the encoded message arguments when the client passes > > them back in a call to SQLCAMESSAGE (see DERBY-1178 for additional > > discussion of this behavior). > > We would like to extract that logic and place it into a new MessageUtils > > class in the common shared library so that both the client and server > > can manipulate the message arguments without duplicating the code. > > > > -- > This message was sent by Atlassian JIRA > (v6.3.4#6332) >
