[
https://issues.apache.org/jira/browse/DERBY-5944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118431#comment-15118431
]
Bryan Pendleton commented on DERBY-5944:
----------------------------------------
I successfully applied the patches to the 4 files and had no build problems.
I interactively ran PlanExporter and verified that the "help" and "no such
schema"
messages were properly displayed.
I ran the XplainStatisticsTest successfully. I think that might be the only
test suite
that we have that exercises PlanExporter in any way.
Is there any other testing to be done? Is this patch ready to be committed to
trunk?
> The hard-coded PlanExporter help message should be internationalized so that
> it can be translated
> -------------------------------------------------------------------------------------------------
>
> Key: DERBY-5944
> URL: https://issues.apache.org/jira/browse/DERBY-5944
> Project: Derby
> Issue Type: Bug
> Components: Localization, Tools
> Affects Versions: 10.10.1.1
> Reporter: Rick Hillegas
> Assignee: Yun Fang
> Labels: derby_triage10_11
> Attachments: MessageVetter.java.diff, PlanExporter.java.diff,
> toolsmessages.properties.diff, toolsmessages_zh_CN.properties.diff
>
>
> The help message for PlanExporter is hard-coded in PlanExporter.printHelp().
> In contrast, other Derby tools use the message lookup logic for their help
> messages. This means that for those other tools, on supported locales, users
> see translated versions of the help messages. For PlanExporter, the help
> message always appears in English. PlanExporter should use the message lookup
> logic like the other tools do.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
