[ 
https://issues.apache.org/jira/browse/DERBY-4091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15200752#comment-15200752
 ] 

Bryan Pendleton commented on DERBY-4091:
----------------------------------------

Hi Sandeep,

I think your patch looks good. I had no problems applying it and running the 
test.

It appears that we may not know what the "size problem" in the test code refers 
to.

I looked through the old mailing lists, and I looked at DERBY-2134, which was 
the
original contribution of the test suite, and there was no discussion of that 
column
there. There were some other MailJdbc test problems over the years, including
DERBY-4294 and DERBY-4152, but neither of them seem related to this column.

My opinion is that we have done a reasonable amount of investigation, and
there is a good likelihood that the "size problem" no longer exists in Derby, 
and
so removing that column from the test is justified.

I intend to commit your patch.

At some point in the future, if DERBY-6877 is implemented, it is possible that
we might encounter the size problem. If so, I feel that we should investigate
it at the point that we are able to reproduce it.

> Investigate "size_problem" column in MailJdbc terst
> ---------------------------------------------------
>
>                 Key: DERBY-4091
>                 URL: https://issues.apache.org/jira/browse/DERBY-4091
>             Project: Derby
>          Issue Type: Task
>          Components: Test
>    Affects Versions: 10.5.1.1
>            Reporter: Kathey Marsden
>            Priority: Minor
>         Attachments: Activity.out, DERBY-4091-2.diff
>
>
> In the MailJdbc test there is a table 
> CREATE TABLE inbox (id bigint generated always as identity (start with 
> 1,increment by 1),
>                                       from_name varchar(64),
>                                       to_name varchar(64),
>                                       message clob(3M),
>                                       date timestamp,
>                                       folder_id Integer,
>                                       to_delete smallint default 0,
>                                       exp_date timestamp,
>                                       attach_id smallint default 0,
>                                       size_problem varchar(32672),
>                                       CONSTRAINT inbox__pk PRIMARY KEY (id));
>                                       
> Which has a column "size_problem". We always insert into this column the value
>                               insertFirst
>                                               .setString(
>                                                               6,
>                                                               "This column is 
> used only to by pass the space problem. If the problem still exists, then we 
> are going to "
>                                                                               
> + "have a serious issue 
> here.*****************************************************************************************************");
> Which seems to imply there is some bug  that manifests itself if we don't 
> have this column, but I don't see a bug reference.  It would be interesting 
> to take the column out and see what happens.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to