[
https://issues.apache.org/jira/browse/DERBY-6856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266208#comment-15266208
]
Knut Anders Hatlen commented on DERBY-6856:
-------------------------------------------
Looks like a good cleanup. +1 to commit.
Some nits:
{noformat}
---
java/testing/org/apache/derbyTesting/functionTests/tests/lang/CollationTest.java
(revision 1737511)
+++
java/testing/org/apache/derbyTesting/functionTests/tests/lang/CollationTest.java
(working copy)
@@ -1835,7 +1835,7 @@
" y char(100))");
s.execute("create table assocout(x char(10))");
ps = prepareStatement("insert into assoc values (?, 'hello')");
- ps.setString(1, new Integer(10).toString());
+ ps.setString(1, Integer.toString(10));
ps.executeUpdate();
{noformat}
Maybe just {{ps.setString(1, "10");}} here?
{noformat}
---
java/testing/org/apache/derbyTesting/functionTests/tests/jdbc4/StatementTest.java
(revision 1737511)
+++
java/testing/org/apache/derbyTesting/functionTests/tests/jdbc4/StatementTest.java
(working copy)
@@ -703,7 +703,7 @@
(
"setLargeMaxRows",
new Class[] { Long.TYPE },
- new Object[] { new Long( max ) }
+ new Object[] { (long) max }
);
{noformat}
max is already a long, so the cast is redundant.
> Make it possible to build Derby using JDK 9
> -------------------------------------------
>
> Key: DERBY-6856
> URL: https://issues.apache.org/jira/browse/DERBY-6856
> Project: Derby
> Issue Type: Improvement
> Components: Build tools
> Affects Versions: 10.12.1.1
> Reporter: Rick Hillegas
> Attachments: derby-6856-01-ab-addShardingKey.diff,
> derby-6856-01-ac-cleanup.diff, derby-6856-02-aa-addShardingKey.diff,
> derby-6856-03-aa-autoboxingDeprecationWarnings.diff
>
>
> Derby can't be built with JDK 9. Java 9 introduces new JDBC classes like
> java.sql.ShardingKey and methods which refer to these new classes.
> In addition, project Jigsaw has created a new way to name classes (see
> http://openjdk.java.net/jeps/220). This breaks the PropertySetter build tool
> which we use so that old JVMs can compile Derby and so that Derby can be
> compiled to run on old JVMs.
> It is likely that we will need to leave this issue open throughout the
> development cycle of Java 9.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
