[ 
https://issues.apache.org/jira/browse/DERBY-6892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352993#comment-15352993
 ] 

Bryan Pendleton commented on DERBY-6892:
----------------------------------------

I'm still a bit confused as to why it is necessary to swap the order of the
'replace' and 'lobsInExtFile' arguments in Import.importTable.

I understand that all the variadic arguments at the end need to be of the same 
type.

But, the variadic args can be zero or more arguments, right?

So, couldn't we make the signature of Import.importTable be:
{code}
    public static void importTable(Connection connection, String schemaName,
                                   String tableName, String inputFileName,
                                   String columnDelimiter,
                                   String characterDelimiter,String codeset,
                                   short replace, boolean lobsInExtFile,
                                   short... extraArgs )
{code}

Then it seems like none of the existing callers of the method would need to
change, and the only caller providing the new 'extraArgs' argument would be
our new SYSCS_IMPORT_TABLE_BULK procedure, which would specify
the 'skip' value.




> Create new SYSCS_IMPORT_TABLE_BULK procedure
> --------------------------------------------
>
>                 Key: DERBY-6892
>                 URL: https://issues.apache.org/jira/browse/DERBY-6892
>             Project: Derby
>          Issue Type: Sub-task
>          Components: SQL
>            Reporter: Bryan Pendleton
>            Assignee: Danoja Dias
>            Priority: Minor
>         Attachments: Derby-6892.diff, addNewSystemProcedure.diff
>
>
> As a sub-task of DERBY-4555, we propose to create a new
> system procedure, SYSCS_IMPORT_TABLE_BULK, which supports
> all the functionality of SYSCS_IMPORT_TABLE, but additionally supports 
> skipping multi-line column headers in the input file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to