[
https://issues.apache.org/jira/browse/DERBY-6895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381609#comment-15381609
]
Bryan Pendleton commented on DERBY-6895:
----------------------------------------
These documentation patches look very good to me. Here are a few observations:
1) I think the filenames would be clearer if we just used 'bulk' instead of
'procwithheaderlines',
so the filenames could be:
{code}
src/ref/rrefimporttablebulk.dita
{code}
and
{code}
src/ref/rrefimportdatabulk.dita
{code}
2) I think we could probably combine both new procedure documents into a single
patch
3) I think SYSCS_IMPORT_DATA_BULK description for COLUMNINDEXES should say that
the input file columns can only be referenced by the header name if the SKIP
argument is greater than 0.
4) I think it would be nice if the SYSCS_IMPORT_DATA_BULK Examples could
include *two* examples. Your first example is fine, and nicely shows the input
file column headers on a single line. It would be nice if there was a second
example, which showed the column headers on multiple lines, and showed how you
could refer to them with, for example, SKIP == 3.
5) I think it would be nice if the final patch could also include the small
improvements to the SYSCS_IMPORT_TABLE and SYSCS_IMPORT_DATA pages that we
discussed.
The documentation looks very good to me. Thanks for working on this!
> Add documentation for new SYSCS_IMPORT_TABLE_BULK, SYSCS_IMPORT_DATA_BULK
> procedures
> ------------------------------------------------------------------------------------
>
> Key: DERBY-6895
> URL: https://issues.apache.org/jira/browse/DERBY-6895
> Project: Derby
> Issue Type: Sub-task
> Components: SQL
> Reporter: Bryan Pendleton
> Assignee: Danoja Dias
> Priority: Minor
> Attachments: derby-6892-doc.zip, derby6892.diff, derby6895-doc.zip,
> derby6895.diff, rrefimporttableprocwithheaderlines.html
>
>
> The new system procedures proposed to be added by DERBY-4555
> need to be documented.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)