I finally got back to this issue hat have been laying around for way too long. I have attached a new patch to JIRA that should address Suresh's review comments. Could someone please review it?
-- Øystein >>>>> "ØG" == Øystein Grøvlen (JIRA) <[email protected]> writes: ØG> [ http://issues.apache.org/jira/browse/DERBY-298?page=comments#action_12361100 ] ØG> Ãystein Grøvlen commented on DERBY-298: ØG> --------------------------------------- ØG> The recently attached patch (derby-298a.diff) addresses Suresh's ØG> review comments. The only major change from the previous patch is in ØG> java/engine/org/apache/derby/impl/store/raw/log/Scan.java. The changes ØG> to this file compared to the current head of trunk are: ØG> - When a new log file is entered, check that the header of this ØG> file refers to the end of the last log record of the previous log ØG> file. If not, stop the scan. ØG> - If the header was consistent, update knowGoodLogEnd to the first ØG> possible LogInstant of this file (end of header). ØG> - close() no longer reset knownGoodLogEnd since it is needed by ØG> FileLogger after the scan is closed. ØG> - Changed comment of getLogRecordEnd() to reflect that it can be ØG> used after the scan is closed, and that it at that time may ØG> return the start of an empty log file. ØG> - Removed comment about not starting to write to the new empty log ØG> file, since that is not true anymore. ØG> In addition, the property files for the tests have been updated so ØG> they are run without the security manager. ØG> derbyall has been run with no new failures.
