[
https://issues.apache.org/jira/browse/DERBY-5261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16086798#comment-16086798
]
Bryan Pendleton commented on DERBY-5261:
----------------------------------------
Thank you for the patch contribution!
It would be nice to have a regression test to go with this change.
Do you think it would be possible to add a regression test to the test suite
NetworkServerControlClentCommandTest.java
in the package
java\testing\org\apache\derbyTesting\functionTests\tests\derbynet ?
An alternate idea would be to add a new test suite in the package
java\testing\org\apache\derbyTesting\functionTests\tests\tools, modeled after
the test suite derbyrunjartest.java ?
Which one of these seems like it would be a better location for a regression
test?
Do you think you could contribute a regression test?
> NetworkServerControl prints usage message twice on some errors
> --------------------------------------------------------------
>
> Key: DERBY-5261
> URL: https://issues.apache.org/jira/browse/DERBY-5261
> Project: Derby
> Issue Type: Bug
> Components: Network Server
> Affects Versions: 10.8.1.2
> Reporter: Knut Anders Hatlen
> Assignee: INDIKA KUMARA
> Priority: Minor
> Labels: derby_triage10_9
>
> If you invoke NetworkServerControl with an invalid command, the usage message
> will be printed twice.
> $ java -jar derbynet.jar abc
> Mon Jun 06 10:14:25 CEST 2011 : Command abc is unknown.
> Usage: NetworkServerControl <commands>
> Commands:
> start [-h <host>] [-p <portnumber>] [-noSecurityManager] [-ssl <sslmode>]
> shutdown [-h <host>][-p <portnumber>] [-ssl <sslmode>] [-user <username>]
> [-password <password>]
> ping [-h <host>][-p <portnumber>] [-ssl <sslmode>]
> sysinfo [-h <host>][-p <portnumber>] [-ssl <sslmode>]
> runtimeinfo [-h <host>][-p <portnumber>] [-ssl <sslmode>]
> logconnections {on|off} [-h <host>][-p <portnumber>] [-ssl <sslmode>]
> maxthreads <max>[-h <host>][-p <portnumber>] [-ssl <sslmode>]
> timeslice <milliseconds>[-h <host>][-p <portnumber>] [-ssl <sslmode>]
> trace {on|off} [-s <session id>][-h <host>][-p <portnumber>] [-ssl <sslmode>]
> tracedirectory <traceDirectory>[-h <host>][-p <portnumber>] [-ssl <sslmode>]
> Mon Jun 06 10:14:25 CEST 2011 : No command given.
> Usage: NetworkServerControl <commands>
> Commands:
> start [-h <host>] [-p <portnumber>] [-noSecurityManager] [-ssl <sslmode>]
> shutdown [-h <host>][-p <portnumber>] [-ssl <sslmode>] [-user <username>]
> [-password <password>]
> ping [-h <host>][-p <portnumber>] [-ssl <sslmode>]
> sysinfo [-h <host>][-p <portnumber>] [-ssl <sslmode>]
> runtimeinfo [-h <host>][-p <portnumber>] [-ssl <sslmode>]
> logconnections {on|off} [-h <host>][-p <portnumber>] [-ssl <sslmode>]
> maxthreads <max>[-h <host>][-p <portnumber>] [-ssl <sslmode>]
> timeslice <milliseconds>[-h <host>][-p <portnumber>] [-ssl <sslmode>]
> trace {on|off} [-s <session id>][-h <host>][-p <portnumber>] [-ssl <sslmode>]
> tracedirectory <traceDirectory>[-h <host>][-p <portnumber>] [-ssl <sslmode>]
> Printing it once should be enough.
> The same problem is seen if you don't specify a required argument for an
> option. For example "java -jar derbynet start -p" (no port number).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
