[ 
https://issues.apache.org/jira/browse/DERBY-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16191426#comment-16191426
 ] 

ASF GitHub Bot commented on DERBY-6928:
---------------------------------------

GitHub user InduminiAyomi opened a pull request:

    https://github.com/apache/derby/pull/3

    DERBY-6928:The ODBCMetadataGenerator_getCastInfoForCol( ) method hard codes 
some string values

    org.apache.derby.iapi.types.TypeId.SMALLINT_NAME is used instead of hard 
coding "SMALLINT" in the above method.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/InduminiAyomi/derby trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/derby/pull/3.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3
    
----

----


> The ODBCMetadataGenerator_getCastInfoForCol method hardcodes some string 
> values
> -------------------------------------------------------------------------------
>
>                 Key: DERBY-6928
>                 URL: https://issues.apache.org/jira/browse/DERBY-6928
>             Project: Derby
>          Issue Type: Improvement
>          Components: Build tools
>            Reporter: Hao Zhong
>            Assignee: Indumini Ayomi
>            Priority: Minor
>
> As some values are defined in org.apache.derby.iapi.types.TypeId, it is 
> easier to maintain the code, if we replace them accordingly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to