[ 
https://issues.apache.org/jira/browse/DERBY-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16513130#comment-16513130
 ] 

Rick Hillegas commented on DERBY-6945:
--------------------------------------

Attaching derby-6945-39-aa-javadocCleanup.diff. This patch cleans up another 
tranche of javadoc warnings. Tests passed cleanly with this patch.

I may have embarked on a fool's errand by cleaning up these javadoc warnings. 
Looking through our javadoc targets, I see that we default to setting 
-Xdoclint:none. That turns off the aggressive spew of javadoc warnings which I 
have been correcting. I'm going to stop cleaning up these warnings and move on 
to the substantive problems involved in generating module-away javadoc.

Touches the following files:

{noformat}
M       java/org.apache.derby.engine/org/apache/derby/agg/Aggregator.java
M       
java/org.apache.derby.engine/org/apache/derby/authentication/SystemPrincipal.java
M       java/org.apache.derby.engine/org/apache/derby/catalog/AliasInfo.java
M       java/org.apache.derby.engine/org/apache/derby/catalog/DefaultInfo.java
M       
java/org.apache.derby.engine/org/apache/derby/catalog/GetProcedureColumns.java
M       
java/org.apache.derby.engine/org/apache/derby/catalog/IndexDescriptor.java
M       
java/org.apache.derby.engine/org/apache/derby/catalog/Java5SystemProcedures.java
M       
java/org.apache.derby.engine/org/apache/derby/catalog/SequencePreallocator.java
M       java/org.apache.derby.engine/org/apache/derby/catalog/Statistics.java
M       
java/org.apache.derby.engine/org/apache/derby/catalog/SystemProcedures.java
M       
java/org.apache.derby.engine/org/apache/derby/catalog/TypeDescriptor.java
M       java/org.apache.derby.engine/org/apache/derby/catalog/UUID.java
M       java/org.apache.derby.engine/org/apache/derby/database/Database.java
D       
java/org.apache.derby.engine/org/apache/derby/iapi/db/ConnectionInfo.java
M       java/org.apache.derby.engine/org/apache/derby/iapi/db/Database.java
M       java/org.apache.derby.engine/org/apache/derby/iapi/db/Factory.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/db/OptimizerTrace.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/db/TriggerExecutionContext.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/jdbc/AuthenticationService.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/jdbc/BrokeredCallableStatement.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/jdbc/BrokeredConnection.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/jdbc/BrokeredConnection42.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/jdbc/BrokeredConnectionControl.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/jdbc/BrokeredPreparedStatement.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/jdbc/BrokeredStatementControl.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/jdbc/ConnectionContext.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/jdbc/DRDAServerStarter.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/jdbc/EmbeddedDataSourceInterface.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/jdbc/EngineConnection.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/jdbc/EnginePreparedStatement.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/jdbc/EngineResultSet.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/jdbc/FailedProperties40.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/jdbc/InternalDriver.java
M       java/org.apache.derby.engine/org/apache/derby/iapi/jdbc/JDBCBoot.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/jdbc/ResourceAdapter.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/cache/CacheFactory.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/cache/CacheManager.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/cache/Cacheable.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/cache/CacheableFactory.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/cache/ClassSize.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/context/Context.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/context/ContextManager.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/context/ContextService.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/crypto/CipherFactory.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/crypto/CipherFactoryBuilder.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/crypto/CipherProvider.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/daemon/DaemonFactory.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/daemon/IndexStatisticsDaemon.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/daemon/Serviceable.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/diag/Diagnosticable.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/io/AccessibleByteArrayOutputStream.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/io/ArrayInputStream.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/io/ArrayOutputStream.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/io/CompressedNumber.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/io/CounterOutputStream.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/io/DynamicByteArrayOutputStream.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/io/FileUtil.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/io/FormatableArrayHolder.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/io/FormatableBitSet.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/io/FormatableInstanceGetter.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/io/InputStreamUtil.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/io/Limit.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/io/LimitInputStream.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/io/LimitReader.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/io/RegisteredFormatIds.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/io/StreamStorable.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/jmx/ManagementService.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/loader/ClassFactory.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/loader/ClassFactoryContext.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/loader/ClassInfo.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/loader/ClassInspector.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/loader/GeneratedByteCode.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/loader/GeneratedClass.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/loader/GeneratedMethod.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/loader/InstanceGetter.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/loader/JarReader.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/locks/Latch.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/locks/LockFactory.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/locks/LockOwner.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/locks/Lockable.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/monitor/ModuleControl.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/property/PersistentSet.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/property/PropertyFactory.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/property/PropertyUtil.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/uuid/UUIDFactory.java
M       java/org.apache.derby.engine/org/apache/derby/iapi/sql/Activation.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/sql/LanguageFactory.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/sql/ParameterValueSet.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/sql/PreparedStatement.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/sql/ResultColumnDescriptor.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/sql/ResultDescription.java
M       java/org.apache.derby.engine/org/apache/derby/iapi/sql/ResultSet.java
M       java/org.apache.derby.engine/org/apache/derby/iapi/sql/Row.java
M       java/org.apache.derby.engine/org/apache/derby/iapi/sql/Statement.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/sql/conn/LanguageConnectionContext.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/sql/dictionary/DataDictionary.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/sql/dictionary/RoleGrantDescriptor.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/sql/dictionary/SPSDescriptor.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/sql/dictionary/TableDescriptor.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/sql/execute/ExecAggregator.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/sql/execute/ResultSetFactory.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/store/access/AccessFactory.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/store/access/BackingStoreHashtable.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/store/access/ColumnOrdering.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/store/access/Qualifier.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/store/access/RowUtil.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/store/access/SpaceInfo.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/store/access/StoreCostController.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/store/access/StoreCostResult.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/store/access/TransactionController.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/store/access/conglomerate/ScanManager.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/store/access/conglomerate/TransactionManager.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/store/raw/ContainerHandle.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/store/raw/ContainerLock.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/store/raw/Loggable.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/store/raw/RawStoreFactory.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/store/raw/Undoable.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/types/RawToBinaryFormatStream.java
M       java/org.apache.derby.engine/org/apache/derby/iapi/types/Resetable.java
M       java/org.apache.derby.engine/org/apache/derby/iapi/types/SQLBinary.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/util/InterruptStatus.java
M       java/org.apache.derby.engine/org/apache/derby/iapi/util/StringUtil.java
M       
java/org.apache.derby.engine/org/apache/derby/impl/jdbc/EmbedResultSet.java
M       
java/org.apache.derby.engine/org/apache/derby/impl/jdbc/TransactionResourceImpl.java
M       java/org.apache.derby.engine/org/apache/derby/mbeans/JDBCMBean.java
M       java/org.apache.derby.engine/org/apache/derby/vti/AwareVTI.java
M       java/org.apache.derby.engine/org/apache/derby/vti/ForeignTableVTI.java
M       java/org.apache.derby.engine/org/apache/derby/vti/ForwardingVTI.java
M       java/org.apache.derby.engine/org/apache/derby/vti/IFastPath.java
M       java/org.apache.derby.engine/org/apache/derby/vti/IQualifyable.java
M       java/org.apache.derby.engine/org/apache/derby/vti/Pushable.java
M       java/org.apache.derby.engine/org/apache/derby/vti/RestrictedVTI.java
M       java/org.apache.derby.engine/org/apache/derby/vti/Restriction.java
M       java/org.apache.derby.engine/org/apache/derby/vti/StringColumnVTI.java
M       java/org.apache.derby.engine/org/apache/derby/vti/VTIContext.java
M       java/org.apache.derby.engine/org/apache/derby/vti/VTIEnvironment.java
M       
java/org.apache.derby.engine/org/apache/derby/vti/VTIMetaDataTemplate.java
M       java/org.apache.derby.engine/org/apache/derby/vti/VTITemplate.java
M       java/org.apache.derby.engine/org/apache/derby/vti/XmlVTI.java
M       java/org.apache.derby.engine/org/apache/derby/vti/package.html
{noformat}


> Re-package Derby as a collection of jigsaw modules
> --------------------------------------------------
>
>                 Key: DERBY-6945
>                 URL: https://issues.apache.org/jira/browse/DERBY-6945
>             Project: Derby
>          Issue Type: Improvement
>    Affects Versions: 10.13.1.2
>            Reporter: Rick Hillegas
>            Priority: Major
>         Attachments: derby-6945-01-aa-remove_derbyPreBuild_dep.diff, 
> derby-6945-02-ab-newDerbySharedJar.diff, 
> derby-6945-02-ac-newDerbySharedJar.diff, derby-6945-03-aa-partitionTest.diff, 
> derby-6945-04-aa-moveRunClass.diff, 
> derby-6945-05-aa-removeRedundant_Attribute_SQLState.diff, 
> derby-6945-06-aa-removeOtherSharedDuplicates.diff, 
> derby-6945-07-aa-net_client_overlap.diff, 
> derby-6945-08-aa-move_shared_iapi_under_shared.diff, 
> derby-6945-08-ab-move_shared_iapi_under_shared.diff, 
> derby-6945-08-ad-move_shared_iapi_under_shared.diff, 
> derby-6945-09-ab-moveInternalDriver.diff, derby-6945-10-aa-moveDriver42.diff, 
> derby-6945-11-ab-moveAutoloadedDriver.diff, 
> derby-6945-12-ab-moveClientDataSourceInterface.diff, 
> derby-6945-13-aa-create-ClientAutoloadedDriver.diff, 
> derby-6945-14-aa-moveMoreEmbeddedClassesOutOfPublicAPI.diff, 
> derby-6945-15-aa-moveMoreClientClassesOutOfPublicAPI.diff, 
> derby-6945-16-aa-consolidatePublicAPI.diff, 
> derby-6945-17-aa-resealPackagesIn-derbyshared.diff, 
> derby-6945-18-aa-resealLocalizationPackage.diff, 
> derby-6945-19-ad-movePublicAPIintoToolsJar.diff, 
> derby-6945-20-aa-removeClasslister.diff, 
> derby-6945-21-aa-simplifyBuildScripts.diff, 
> derby-6945-21-ab-simplifyBuildScripts.diff, 
> derby-6945-22-ad-isolateClassesByArtifact.diff, 
> derby-6945-22-ae-isolateClassesByArtifact.diff, 
> derby-6945-22-af-isolateClassesByArtifact.diff, 
> derby-6945-23-aa-upgradeToAnt_1.10.2.diff, 
> derby-6945-24-aa-fixNativeAuthenticationServiceTest.diff, 
> derby-6945-25-ab-moduleDescriptors.diff, 
> derby-6945-26-aa-packagePrivateTests.diff, 
> derby-6945-27-aa-adjustModulesForTests.diff, 
> derby-6945-28-aa-testingModuleDescriptor.diff, 
> derby-6945-29-aa-disable-SimpleApp-test.diff, 
> derby-6945-30-ab-move-clientmessages-toolsmessages.diff, 
> derby-6945-31-aa-clientmessages-ResourceBundleProvider.diff, 
> derby-6945-32-aa-messageLookupCleanup.diff, 
> derby-6945-33-ab-moveLocalizations.diff, 
> derby-6945-34-aa-licenseHeaders.diff, 
> derby-6945-35-aa-removeSpuriousCharacter.diff, 
> derby-6945-36-aa-moduleDescriptorsForLocaleJars.diff, 
> derby-6945-38-aa-javadocCleanup.diff, derby-6945-39-aa-javadocCleanup.diff, 
> derby-6945-XX-moveDataSourceFactories, jdeps.out.tar, weirdAnt.out
>
>
> Once we commit to building with Java 9 (see DERBY-6856), we should consider 
> re-packaging Derby as a set of jigsaw modules. This would result in a 
> different set of release artifacts. This might be a good opportunity to 
> address the Tomcat artifactory issues raised by issue DERBY-6944.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to