[ 
http://issues.apache.org/jira/browse/DERBY-398?page=comments#action_12362084 ] 

Kathey Marsden commented on DERBY-398:
--------------------------------------

Regarding jdk14_tests.diff, I could not apply to the latest trunk  because 
RunList.java seems to have a recent update.

I applied the patch to the older version and it look ok but have a couple 
questions  :

ij.database and ij.protocol being removed from the System.Properties.  Where 
are  they being set?
It seems it would be better to never set them than  add and then removed later.

For the test harness there were changes made  to RunList to change jdk14test to 
jdbc30 test.
We have another property runwith<jdk>=false that is used for some tests to 
disable running with jdk 1..3.1.
I wonder, would be better to just get rid of the jdk14test property all 
together and use runwithjdk13=false and
runwithibm13=false?

This is not a show stopper, just a thought.   jdk14test always seemed like an 
odd property since it only works at the list level.  I think it predates the 
runwith<jvm> property.

Please resubmit the patch after  merging.  I will try to pay quick attention to 
it so there are not merge conflicts. 




> Exclude tests for J2ME/CDC/Foundation platform
> ----------------------------------------------
>
>          Key: DERBY-398
>          URL: http://issues.apache.org/jira/browse/DERBY-398
>      Project: Derby
>         Type: Sub-task
>   Components: Test
>     Reporter: Deepa Remesh
>     Assignee: Deepa Remesh
>  Attachments: derby-398_2.diff, derby-398_2.status, derbyall_report_2.txt, 
> jdbcapi_lang_patch.diff, jdbcapi_lang_patch.status, jdk14_tests.diff, 
> jdk14_tests.status, nullSQLText_patch.diff, nullSQLText_patch.status, 
> readme_patch.diff, store_patch.diff, store_patch.status, 
> wisconsin_patch.diff, wisconsin_patch.status
>
> Exclude tests which use DriverManager, Driver or BigDecimal classes which are 
> not in J2ME or JSR169. Ensure that derbyall can be run successfully in 
> J2ME/CDC/Foundation platform using the JDBC Optional Package for 
> CDC/Foundation Profile (JSR169).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to