>>>>>>>>>>>> Knut Anders Hatlen wrote (2006-01-11 08:41:06): > Bryan Pendleton <[EMAIL PROTECTED]> writes: > > > Knut Anders Hatlen (JIRA) wrote: > >> I have uploaded a new patch (DERBY-212-parsePKGNAMCSN-2.diff) where I > >> have tried to address Bryan's review comments. > > > > Hi Knut Anders, > > > > I read through your changes and they look good to me. Thanks for > > taking the time to investigate my comments. I have no further > > comments or suggestions. > > Thanks again for reading my patch, Bryan. > > > How does the performance look with these latest changes? Are the > > results with this patch more or less in line with your expectations? > > It seems like the simplification of DRDAString had a small positive > effect, but it's hard to say exactly since the (imagined) increase was > at about the same size as the noise. The other changes had very little > impact on the performance, so I think the readability changes were > worthwhile. > > Then we'll just have to wait for a committer's attention. Any > volunteers? :)
I volunteer.... > > -- > Knut Anders > -- Bernt Marius Johnsen, Database Technology Group, Staff Engineer, Technical Lead Derby/Java DB Sun Microsystems, Trondheim, Norway
pgpFcZoFl1wtA.pgp
Description: PGP signature
