Rick Hillegas wrote: > Hi Kathey, > > I have clipped to JIRA-499 a fix for these regressions. Thanks for the > heads-up about the version numbers in the canons. I finessed that > issue by removing the volatile numbers from the canons. Instead, the > metadata test now compares version numbers internally and only emits > diff-triggering output if it detects a discrepancy. Keeping this test > in sync with the version variables in dnc.properties now involves a > couple edits to metadata.java rather than updating 10 canons.
I think I don't like this approach of putting the derby version in the metadata a test because it doesn't provide a centralized place to bump the version for all the tests affected. Right now to bump the version you run the tools/bumplastdigit target (See http://wiki.apache.org/db-derby/DerbySnapshotOrRelease). With this patch, you would have to run that plus change this one test. Also I think the release instructions would need to be changed,. Thanks Kathey
