[ http://issues.apache.org/jira/browse/DERBY-796?page=comments#action_12362860 ]
Daniel John Debrunner commented on DERBY-796: --------------------------------------------- The patch lacks comments, the methods that have changed from being not implemented have no java doc or comments. New methods added such as atLeast have no comments, the entire class ClientJDBCObjectFactory has no comments. I think EmbedPreparedStatement40.setClob()/setBlob() should be calling setCharacterStreamInternal()/setBinaryStreamInternal(). This would remove the need for reader/stream being null checks. I'm worried by this patch, or maybe previous patches in this series, reflection is used to allocate JDBC objects on the client, reflection is really slow, how often is this code invoked? E.g. is a NetResultSet allocated through reflection every time a ResultSet is returned to the client? The whole class ClientJDBCObjectFactory looks terrible for performance, creating any JDBC object now involves many object creations, which will slow down performance, even the the objects which could be static (the Class arrays) are created on very method call. Why was reflection used instead of a factory pattern like the embedded driver? I think at sometime we need some performance tests to ensure client performance has not regressed from 10.1 > jdbc 4.0 specific Blob and Clob method support > ---------------------------------------------- > > Key: DERBY-796 > URL: http://issues.apache.org/jira/browse/DERBY-796 > Project: Derby > Type: New Feature > Components: JDBC > Versions: 10.2.0.0 > Environment: jdbc 4.0 on all platforms > Reporter: V.Narayanan > Assignee: V.Narayanan > Priority: Minor > Fix For: 10.2.0.0 > Attachments: lob.diff > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
