TomohitoNakayama wrote:
>
>
>> 3) Code Formatting - There seem to be code indentation
>> inconsistencies in DDMWriter. Also I think it is good to indent the
>> method bodies in the new methods in ReEncodedInputStream.java.
>> Things sort of run together.
>>
> Reading comments from others, I think a patch for code formatting
> should be submitted separately from,
> because modification of code formatting would make it much difficult
> to read the patch.
>
My previous comment was regarding the places where new code uses reverse
indentation or no indentation, not reformatting existing code. We don't
have formatting guidelines but I think code blocks should be indented.
Examples:
In writeScalarStream (reverse indentation for try block)
try {
boolean isLastSegment = false;
......
ReEnCodedInputStream (no indentation for method bodies)
Example:
protected void finalize() throws IOException {
close();
}
I will post more comments on the patch to Jira
Thanks
Kathey
