[ http://issues.apache.org/jira/browse/DERBY-819?page=comments#action_12362976 ]
Daniel John Debrunner commented on DERBY-819: --------------------------------------------- -1 on the patch No comments on any of the new code. I couldn't understand why there is a JDBC40SQLExceptionFactory class but the SQLExceptionFactory. also has checks for being in JDK1.6 and returning JDBC 4.0 objects. The embedded JDBC driver already has a factory for JDBC objects, InternalDriver. Can this existing mechanism be used for SQLExceptions? At one point I thought the JDBC 4.0 spec had a static method for returning the correct SQLException type from a SQLState, like your code in JDBC40ExceptionFactory, was this removed or did I imagine it? > Provide JDBC4 SQLException subclasses support in Embedded driver > ---------------------------------------------------------------- > > Key: DERBY-819 > URL: http://issues.apache.org/jira/browse/DERBY-819 > Project: Derby > Type: Sub-task > Components: JDBC > Environment: all > Reporter: Anurag Shekhar > Assignee: Anurag Shekhar > Priority: Minor > Attachments: embedexception.diff, stat.out > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
