[ http://issues.apache.org/jira/browse/DERBY-400?page=all ]
David Van Couvering updated DERBY-400:
--------------------------------------
Attachment: DERBY-400.diff
This patch includes the following changes. I know I have the karma to check
this in directly, but I would like it to be reviewed if someone has the
inclination. I am in the middle of running tests. I can check it in once
tests pass and the review comments have been addressed.
- Based on Dan's review comments for the last incarnation of this patch,
org.apache.derby.client.am.SqlException no longer extends java.sql.SQLException
in preparation for JDBC4 support.
- All public JDBC methods now throw SQLException instead of SqlException. They
generally catch SqlException and convert this to SQLException using a utility
routine on SqlException. This was a *lot* of work and the diff is quite large.
- Some internal methods call public JDBC methods. These methods need to
continue throwing SqlException or you end up with the majority of internal code
having to handle and/or throw SQLException. So these internal methods take
SQLExceptions and wrap them in a SqlException. The underlying SQLException is
then "unwrapped" prior to throwing the exception to the application code
- I have added new constructors on SqlException that take a message id instead
of a hardcoded string. I use a simple wrapper class, MessageId, to hold the
message id, otherwise the old constructors for SqlException have matching
signatures and the compiler complains (as well it should). This wrapper class
can be refactored out once the i18n conversion is complete.
- I have added code in org.apache.derby.shared.common that provides utility
routines for i18n and exception management. This code is currently only used
by the client side.
- I have migrated about a dozen client-side messages to be internationalized
> Network client message strings not localized
> --------------------------------------------
>
> Key: DERBY-400
> URL: http://issues.apache.org/jira/browse/DERBY-400
> Project: Derby
> Type: Improvement
> Components: Network Client
> Versions: 10.1.1.0
> Reporter: David Van Couvering
> Assignee: David Van Couvering
> Priority: Minor
> Attachments: DERBY-400.diff
>
> In investigating DERBY-254, I discovered that all SQLExceptions are thrown
> with hardcoded English error messages. This needs to be modified to use
> message string resource bundles similar to the embedded code.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
