Anders Morken: > Bryan Pendleton: > > Knut Anders Hatlen (JIRA) wrote: > > > [ http://issues.apache.org/jira/browse/DERBY-816?page=all ] > > > > I believe there are also some places in the client code where it > > could be beneficial to use System.arraycopy and/or Arrays.fill. > > For example, in Reply.compressBLayerData() in Reply.java there is > > such a case: > > This seemed like something suitable for a novice, so I've picked up a > couple of instances of this (So far in Reply.java and Request.java), and > changed them to use System.arrayCopy() and Arrays.fill(). I'm running > tests now, and unless it breaks or I find more stuff to mess with I'll > stick a patch in JIRA before going to bed. =)
Created a sub-task of DERBY-212 in JIRA for these patches, DERBY-823. For some reason it's flagged as a "Major" priority, which is obviously wrong, but I can't change it. I hope they don't break anything. Sanity checking would be appreciated, I made the changes without understanding any of the code of the code surrounding the patches. =) -- Anders Morken My opinions may have changed, but not the fact that I am right!
