Re: svn commit: r370815 [1/2] - in /db/derby/code/trunk: ./ java/build/org/apache/derbyBuild/ java/client/org/apache/derby/client/am/ java/client/org/apache/derby/loc/ java/engine/org/apache/derby/iapi/error/ java/engine/org/apache/derby/iapi/reference/ ja...

[David W. Van Couvering]

Part of the reason I committed this without waiting for review was that 
I removed the change where SqlException no longer extends SQLException 
so I thought it was pretty straightforward.

I am still trying to understand/learn when a committer should submit a 
patch for review versus just commit.  Does anyone have any guidelines 
for this?

Thanks,

David

Kathey Marsden wrote:
Andrew McIntyre wrote:



Sorry I didn't get around to looking at this until after you 
committed the patch, but:


I will revew post commit as well. Somehow I got it into my head that the
patch was on hold while a hang was being figured out, but I guess that
was another issue.  Anyway I will get back with comments.

Kathey




begin:vcard
fn:David W Van Couvering
n:Van Couvering;David W
org:Sun Microsystems, Inc.;Database Technology Group
email;internet:[EMAIL PROTECTED]
title:Senior Staff Software Engineer
tel;work:510-550-6819
tel;cell:510-684-7281
x-mozilla-html:TRUE
version:2.1
end:vcard