I'll have a look at it and possibly commit it.... >>>>>>>>>>>> Knut Anders Hatlen wrote (2006-01-25 09:59:36): > "Bryan Pendleton (JIRA)" <[email protected]> writes: > > > [ http://issues.apache.org/jira/browse/DERBY-491?page=all ] > > > > Bryan Pendleton updated DERBY-491: > > ---------------------------------- > > > > Attachment: svn_jan_24_2006.diff > > > > Updated patch, against latest trunk. I added a few additional > > comments to this patch to try to explain the changes more clearly, > > and also I added a reference to this bug entry to help the reader > > find more information. Now that DERBY-125 has been committed > > (thanks!), the regression test passes cleanly, and I have also run > > the entire derbyall suite with this patch. > > > > I think that this patch proposal is now ready for review. Kathey, > > Army, other interested reviewers, please have a look and tell me > > what you think! > > Hi Bryan, > > I read through your patch, ran derbynetclientmats and derbynetmats > successfully, and verified that the test case failed without your > patch (actually, it didn't fail, it just hung until I got bored and > killed the test). > > The changes seem correct to me, they are well documented and the test > case looks good. I have no complaints at all about the patch. > > +1 to committing this patch. > > -- > Knut Anders >
-- Bernt Marius Johnsen, Database Technology Group, Staff Engineer, Technical Lead Derby/Java DB Sun Microsystems, Trondheim, Norway
pgpmh9QJN3CNJ.pgp
Description: PGP signature
